Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1u8CBm-00Fc15-E4 for pgsql-docs@arkaria.postgresql.org; Fri, 25 Apr 2025 06:05:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1u8CBk-007JWX-Ie for pgsql-docs@arkaria.postgresql.org; Fri, 25 Apr 2025 06:05:29 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1u8C8f-007Gfk-Gs for pgsql-docs@lists.postgresql.org; Fri, 25 Apr 2025 06:02:18 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by makus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1u8C8d-001qB4-0h for pgsql-docs@lists.postgresql.org; Fri, 25 Apr 2025 06:02:17 +0000 Received: from [192.168.11.5] (p1696134-ipoe.ipoe.ocn.ne.jp [118.0.93.133]) by oss.nttdata.com (Postfix) with ESMTPSA id 219CF61A5D; Fri, 25 Apr 2025 15:02:10 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at oss.nttdata.com Message-ID: Date: Fri, 25 Apr 2025 15:02:09 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Remove unnecessary secondary index terms for replication settings To: Robert Treat , euler@eulerto.com Cc: pgsql-docs@lists.postgresql.org References: Content-Language: en-US From: Fujii Masao In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2025/04/24 23:30, Robert Treat wrote: > On Wed, Apr 23, 2025 at 2:54 AM Fujii Masao wrote: >> >> Hi, >> >> In config.sgml, the entries for max_replication_slots and >> max_active_replication_origins include secondary index terms: >> >> max_replication_slots configuration parameter >> in a sending server >> >> max_active_replication_origins configuration parameter >> in a subscriber >> >> These secondary terms don't seem necessary anymore, since each parameter >> now has only one index entry. Removing them would simplify the documentation. >> >> Originally, the secondary entries made sense because >> max_active_replication_origins was part of max_replication_slots, >> so both needed separate index entries. But commit 04ff636cbce >> split them into distinct parameters. >> >> Patch attached. >> > > Make sense, +1 from me. Thanks both for the review! I've pushed the patch. Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION