Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1r9LkG-00GUGv-Jg
	for pgsql-docs@arkaria.postgresql.org; Sat, 02 Dec 2023 08:53:04 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1r9LkE-00AbtW-U3
	for pgsql-docs@arkaria.postgresql.org; Sat, 02 Dec 2023 08:53:02 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <Shinya11.Kato@oss.nttdata.com>)
	id 1r9LkE-00AbtO-MA
	for pgsql-docs@lists.postgresql.org; Sat, 02 Dec 2023 08:53:02 +0000
Received: from oss.nttdata.com ([49.212.34.109])
	by makus.postgresql.org with esmtps  (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <Shinya11.Kato@oss.nttdata.com>)
	id 1r9Lk7-008PF6-Hj
	for pgsql-docs@lists.postgresql.org; Sat, 02 Dec 2023 08:53:01 +0000
Received: from oss.nttdata.com (localhost [127.0.0.1])
	by oss.nttdata.com (Postfix) with ESMTPA id D39BE61040;
	Sat,  2 Dec 2023 17:52:50 +0900 (JST)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.11 at oss.nttdata.com
MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="=_a1380b2c422518b79c59c1f0c2acec95"
Content-Transfer-Encoding: 7bit
Date: Sat, 02 Dec 2023 17:52:50 +0900
From: Shinya Kato <Shinya11.Kato@oss.nttdata.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: Delete description of trigger file
In-Reply-To: <ZWmExMaaD-NOAdBx@paquier.xyz>
References: <201b08ea29aa61f96162080e75be503c@oss.nttdata.com>
 <ZWmExMaaD-NOAdBx@paquier.xyz>
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <e9c01f395044a75c4eb6a6a130c24cfa@oss.nttdata.com>
X-Sender: Shinya11.Kato@oss.nttdata.com
List-Id: <pgsql-docs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-docs@lists.postgresql.org>
List-Owner: <mailto:pgsql-docs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-docs>
Archived-At: 
 <https://www.postgresql.org/message-id/e9c01f395044a75c4eb6a6a130c24cfa%40oss.nttdata.com>
Precedence: bulk

--=_a1380b2c422518b79c59c1f0c2acec95
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII;
 format=flowed

On 2023-12-01 16:01, Michael Paquier wrote:
> On Fri, Dec 01, 2023 at 11:54:14AM +0900, Shinya Kato wrote:
>>      later disconnected, the standby goes back to step 1 and tries to
>>      restore the file from the archive again. This loop of retries 
>> from the
>>      archive, <filename>pg_wal</filename>, and via streaming 
>> replication goes on until the server
>> -    is stopped or failover is triggered by a trigger file.
>> +    is stopped.
> 
> Just removing this information looks incorrect to me, because a
> promotion would cause the retries to stop the WAL lookups.  Shouldn't
> the last part of this sentence be reworded as of a "or is promoted"?

Thanks for the review.
Yes, that's true. A new patch is attached.

-- 
Regards,
Shinya Kato
NTT DATA GROUP CORPORATION
--=_a1380b2c422518b79c59c1f0c2acec95
Content-Transfer-Encoding: base64
Content-Type: text/x-diff;
 name=v2-0001-delete-description-of-trigger-file.patch
Content-Disposition: attachment;
 filename=v2-0001-delete-description-of-trigger-file.patch;
 size=656

ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9oaWdoLWF2YWlsYWJpbGl0eS5zZ21sIGIvZG9jL3Ny
Yy9zZ21sL2hpZ2gtYXZhaWxhYmlsaXR5LnNnbWwKaW5kZXggZWI4MTI2MGJiZi4uOWRkNTJmZjI3
NSAxMDA2NDQKLS0tIGEvZG9jL3NyYy9zZ21sL2hpZ2gtYXZhaWxhYmlsaXR5LnNnbWwKKysrIGIv
ZG9jL3NyYy9zZ21sL2hpZ2gtYXZhaWxhYmlsaXR5LnNnbWwKQEAgLTY0OCw3ICs2NDgsNyBAQCBw
cm90b2NvbCB0byBtYWtlIG5vZGVzIGFncmVlIG9uIGEgc2VyaWFsaXphYmxlIHRyYW5zYWN0aW9u
YWwgb3JkZXIuCiAgICAgbGF0ZXIgZGlzY29ubmVjdGVkLCB0aGUgc3RhbmRieSBnb2VzIGJhY2sg
dG8gc3RlcCAxIGFuZCB0cmllcyB0bwogICAgIHJlc3RvcmUgdGhlIGZpbGUgZnJvbSB0aGUgYXJj
aGl2ZSBhZ2Fpbi4gVGhpcyBsb29wIG9mIHJldHJpZXMgZnJvbSB0aGUKICAgICBhcmNoaXZlLCA8
ZmlsZW5hbWU+cGdfd2FsPC9maWxlbmFtZT4sIGFuZCB2aWEgc3RyZWFtaW5nIHJlcGxpY2F0aW9u
IGdvZXMgb24gdW50aWwgdGhlIHNlcnZlcgotICAgIGlzIHN0b3BwZWQgb3IgZmFpbG92ZXIgaXMg
dHJpZ2dlcmVkIGJ5IGEgdHJpZ2dlciBmaWxlLgorICAgIGlzIHN0b3BwZWQgb3IgaXMgcHJvbW90
ZWQuCiAgICA8L3BhcmE+CiAKICAgIDxwYXJhPgo=
--=_a1380b2c422518b79c59c1f0c2acec95--