Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lN2Ul-0000h9-I0 for pgsql-hackers@arkaria.postgresql.org; Thu, 18 Mar 2021 23:56:03 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lN2Uk-0003Hp-Df for pgsql-hackers@arkaria.postgresql.org; Thu, 18 Mar 2021 23:56:02 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lN2Uk-0003H7-7H for pgsql-hackers@lists.postgresql.org; Thu, 18 Mar 2021 23:56:02 +0000 Received: from relay11.mail.gandi.net ([217.70.178.231]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lN2Uh-0004KB-JX for pgsql-hackers@lists.postgresql.org; Thu, 18 Mar 2021 23:56:01 +0000 Received: from [172.16.255.146] (14.149.88.79.rev.sfr.net [79.88.149.14]) (Authenticated sender: vik@postgresfriends.org) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 9E8FF100002; Thu, 18 Mar 2021 23:55:53 +0000 (UTC) Subject: Re: GROUP BY DISTINCT To: Tomas Vondra , Tom Lane Cc: Thomas Munro , Georgios Kokolatos , PostgreSQL Hackers , Erik Rijkers References: <161469758801.29967.4455067072614569957.pgcf@coridan.postgresql.org> <4294e82f-a134-5dbb-d9d6-03d72dce2e1e@postgresfriends.org> <3817d5ec-f3e4-e4b9-d169-271ae5d3cbe4@postgresfriends.org> <8c44df08-bb64-3d78-da1a-d24b7c9db39d@enterprisedb.com> <7137947a-87be-d04a-bf91-f42e47520daa@enterprisedb.com> <35077b31-2d62-1e31-0e2e-ddb52d590b73@enterprisedb.com> <3818384.1616106942@sss.pgh.pa.us> <3828009.1616109022@sss.pgh.pa.us> <3858396.1616110003@sss.pgh.pa.us> From: Vik Fearing Message-ID: Date: Fri, 19 Mar 2021 00:55:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 3/19/21 12:52 AM, Tomas Vondra wrote: > > On 3/19/21 12:26 AM, Tom Lane wrote: >> I wrote: >>> This is gcc 4.5, but hopefully whatever shuts it up will also work on 4.7. >>> I'll work on figuring that out. >> >> Actually, the problem is pretty obvious after comparing this use >> of foreach_delete_current() to every other one. I'm not sure why >> the compiler warnings are phrased just as they are, but the fix >> I just pushed does make 4.5 happy. >> > > Thanks! Yeah, that looks obvious. Funny the older compilers noticed > this, not the new fancy ones. +1 I'm glad the buildfarm is so diverse. -- Vik Fearing