Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jeWOz-0006Tc-Jx for pgsql-docs@arkaria.postgresql.org; Fri, 29 May 2020 04:13:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jeWOx-0004lW-Kf for pgsql-docs@arkaria.postgresql.org; Fri, 29 May 2020 04:13:47 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jeWOx-0004l8-9T for pgsql-docs@lists.postgresql.org; Fri, 29 May 2020 04:13:47 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jeWOp-0004CZ-I1 for pgsql-docs@lists.postgresql.org; Fri, 29 May 2020 04:13:45 +0000 Received: from hnk.local (p1864124-ipbf1405funabasi.chiba.ocn.ne.jp [123.216.143.124]) by oss.nttdata.com (Postfix) with ESMTPSA id E32CE602FB; Fri, 29 May 2020 13:13:34 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.102.2 at oss.nttdata.com Subject: Re: wal_init_zero and wal_recycle To: Thomas Munro , Simon Riggs Cc: pgsql-docs@lists.postgresql.org References: From: Fujii Masao Message-ID: Date: Fri, 29 May 2020 13:13:34 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------603780304767152326C58CF6" Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is a multi-part message in MIME format. --------------603780304767152326C58CF6 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 2020/05/28 8:43, Thomas Munro wrote: > On Wed, May 27, 2020 at 7:09 PM Simon Riggs wrote: >> On Wed, 27 May 2020 at 04:27, Fujii Masao wrote: >>> >>> Hi, >>> >>> The group of wal_init_zero and wal_recycle is WAL_SETTINGS in guc.c, >>> but their descriptions are located in "19.6. Replication"/"19.6.1. Sending >>> Servers" section. This seems a documentation bug. They should be located >>> in "19.5. Write Ahead Log"/"19.5.1. Settings". Thought? >> >> >> +1 Thanks! Patch attached. Since they are located just before wal_buffers in postgresql.conf.sample, I moved the descriptions of them also just before that of wal_buffers in "Write Ahead Log"/"Settings" section. BTW, while reading guc.c, I found the GUC context of wal_recycle is PGC_SUSET. But isn't it better to set it to PGC_SIGHUP because wal_recycle doesn't affect any backends? Basically checkpointer and startup process use wal_recycle. Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION --------------603780304767152326C58CF6 Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="wal_guc_docs.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="wal_guc_docs.patch" ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9jb25maWcuc2dtbCBiL2RvYy9zcmMvc2dtbC9j b25maWcuc2dtbAppbmRleCBhMjY5NGU1NDhhLi44NjJiYWFlMGM4IDEwMDY0NAotLS0gYS9k b2Mvc3JjL3NnbWwvY29uZmlnLnNnbWwKKysrIGIvZG9jL3NyYy9zZ21sL2NvbmZpZy5zZ21s CkBAIC0yODIwLDYgKzI4MjAsNDEgQEAgaW5jbHVkZV9kaXIgJ2NvbmYuZCcKICAgICAgIDwv bGlzdGl0ZW0+CiAgICAgIDwvdmFybGlzdGVudHJ5PgogCisgICAgIDx2YXJsaXN0ZW50cnkg aWQ9Imd1Yy13YWwtaW5pdC16ZXJvIiB4cmVmbGFiZWw9IndhbF9pbml0X3plcm8iPgorICAg ICAgPHRlcm0+PHZhcm5hbWU+d2FsX2luaXRfemVybzwvdmFybmFtZT4gKDx0eXBlPmJvb2xl YW48L3R5cGU+KQorICAgICAgPGluZGV4dGVybT4KKyAgICAgICA8cHJpbWFyeT48dmFybmFt ZT53YWxfaW5pdF96ZXJvPC92YXJuYW1lPiBjb25maWd1cmF0aW9uIHBhcmFtZXRlcjwvcHJp bWFyeT4KKyAgICAgIDwvaW5kZXh0ZXJtPgorICAgICAgPC90ZXJtPgorICAgICAgPGxpc3Rp dGVtPgorICAgICAgIDxwYXJhPgorICAgICAgICBJZiBzZXQgdG8gPGxpdGVyYWw+b248L2xp dGVyYWw+ICh0aGUgZGVmYXVsdCksIHRoaXMgb3B0aW9uIGNhdXNlcyBuZXcKKyAgICAgICAg V0FMIGZpbGVzIHRvIGJlIGZpbGxlZCB3aXRoIHplcm9lcy4gIE9uIHNvbWUgZmlsZSBzeXN0 ZW1zLCB0aGlzIGVuc3VyZXMKKyAgICAgICAgdGhhdCBzcGFjZSBpcyBhbGxvY2F0ZWQgYmVm b3JlIHdlIG5lZWQgdG8gd3JpdGUgV0FMIHJlY29yZHMuICBIb3dldmVyLAorICAgICAgICA8 Zmlyc3R0ZXJtPkNvcHktT24tV3JpdGU8L2ZpcnN0dGVybT4gKENPVykgZmlsZSBzeXN0ZW1z IG1heSBub3QgYmVuZWZpdAorICAgICAgICBmcm9tIHRoaXMgdGVjaG5pcXVlLCBzbyB0aGUg b3B0aW9uIGlzIGdpdmVuIHRvIHNraXAgdGhlIHVubmVjZXNzYXJ5CisgICAgICAgIHdvcmsu ICBJZiBzZXQgdG8gPGxpdGVyYWw+b2ZmPC9saXRlcmFsPiwgb25seSB0aGUgZmluYWwgYnl0 ZSBpcyB3cml0dGVuCisgICAgICAgIHdoZW4gdGhlIGZpbGUgaXMgY3JlYXRlZCBzbyB0aGF0 IGl0IGhhcyB0aGUgZXhwZWN0ZWQgc2l6ZS4KKyAgICAgICA8L3BhcmE+CisgICAgICA8L2xp c3RpdGVtPgorICAgICA8L3Zhcmxpc3RlbnRyeT4KKworICAgICA8dmFybGlzdGVudHJ5IGlk PSJndWMtd2FsLXJlY3ljbGUiIHhyZWZsYWJlbD0id2FsX3JlY3ljbGUiPgorICAgICAgPHRl cm0+PHZhcm5hbWU+d2FsX3JlY3ljbGU8L3Zhcm5hbWU+ICg8dHlwZT5ib29sZWFuPC90eXBl PikKKyAgICAgIDxpbmRleHRlcm0+CisgICAgICAgPHByaW1hcnk+PHZhcm5hbWU+d2FsX3Jl Y3ljbGU8L3Zhcm5hbWU+IGNvbmZpZ3VyYXRpb24gcGFyYW1ldGVyPC9wcmltYXJ5PgorICAg ICAgPC9pbmRleHRlcm0+CisgICAgICA8L3Rlcm0+CisgICAgICA8bGlzdGl0ZW0+CisgICAg ICAgPHBhcmE+CisgICAgICAgIElmIHNldCB0byA8bGl0ZXJhbD5vbjwvbGl0ZXJhbD4gKHRo ZSBkZWZhdWx0KSwgdGhpcyBvcHRpb24gY2F1c2VzIFdBTAorICAgICAgICBmaWxlcyB0byBi ZSByZWN5Y2xlZCBieSByZW5hbWluZyB0aGVtLCBhdm9pZGluZyB0aGUgbmVlZCB0byBjcmVh dGUgbmV3CisgICAgICAgIG9uZXMuICBPbiBDT1cgZmlsZSBzeXN0ZW1zLCBpdCBtYXkgYmUg ZmFzdGVyIHRvIGNyZWF0ZSBuZXcgb25lcywgc28gdGhlCisgICAgICAgIG9wdGlvbiBpcyBn aXZlbiB0byBkaXNhYmxlIHRoaXMgYmVoYXZpb3IuCisgICAgICAgPC9wYXJhPgorICAgICAg PC9saXN0aXRlbT4KKyAgICAgPC92YXJsaXN0ZW50cnk+CisKICAgICAgPHZhcmxpc3RlbnRy eSBpZD0iZ3VjLXdhbC1idWZmZXJzIiB4cmVmbGFiZWw9IndhbF9idWZmZXJzIj4KICAgICAg IDx0ZXJtPjx2YXJuYW1lPndhbF9idWZmZXJzPC92YXJuYW1lPiAoPHR5cGU+aW50ZWdlcjwv dHlwZT4pCiAgICAgICA8aW5kZXh0ZXJtPgpAQCAtMzc1Miw0MSArMzc4Nyw2IEBAIHJlc3Rv cmVfY29tbWFuZCA9ICdjb3B5ICJDOlxcc2VydmVyXFxhcmNoaXZlZGlyXFwlZiIgIiVwIicg ICMgV2luZG93cwogICAgICAgIDwvbGlzdGl0ZW0+CiAgICAgICA8L3Zhcmxpc3RlbnRyeT4K IAotICAgICA8dmFybGlzdGVudHJ5IGlkPSJndWMtd2FsLWluaXQtemVybyIgeHJlZmxhYmVs PSJ3YWxfaW5pdF96ZXJvIj4KLSAgICAgIDx0ZXJtPjx2YXJuYW1lPndhbF9pbml0X3plcm88 L3Zhcm5hbWU+ICg8dHlwZT5ib29sZWFuPC90eXBlPikKLSAgICAgIDxpbmRleHRlcm0+Ci0g ICAgICAgPHByaW1hcnk+PHZhcm5hbWU+d2FsX2luaXRfemVybzwvdmFybmFtZT4gY29uZmln dXJhdGlvbiBwYXJhbWV0ZXI8L3ByaW1hcnk+Ci0gICAgICA8L2luZGV4dGVybT4KLSAgICAg IDwvdGVybT4KLSAgICAgIDxsaXN0aXRlbT4KLSAgICAgICA8cGFyYT4KLSAgICAgICAgSWYg c2V0IHRvIDxsaXRlcmFsPm9uPC9saXRlcmFsPiAodGhlIGRlZmF1bHQpLCB0aGlzIG9wdGlv biBjYXVzZXMgbmV3Ci0gICAgICAgIFdBTCBmaWxlcyB0byBiZSBmaWxsZWQgd2l0aCB6ZXJv ZXMuICBPbiBzb21lIGZpbGUgc3lzdGVtcywgdGhpcyBlbnN1cmVzCi0gICAgICAgIHRoYXQg c3BhY2UgaXMgYWxsb2NhdGVkIGJlZm9yZSB3ZSBuZWVkIHRvIHdyaXRlIFdBTCByZWNvcmRz LiAgSG93ZXZlciwKLSAgICAgICAgPGZpcnN0dGVybT5Db3B5LU9uLVdyaXRlPC9maXJzdHRl cm0+IChDT1cpIGZpbGUgc3lzdGVtcyBtYXkgbm90IGJlbmVmaXQKLSAgICAgICAgZnJvbSB0 aGlzIHRlY2huaXF1ZSwgc28gdGhlIG9wdGlvbiBpcyBnaXZlbiB0byBza2lwIHRoZSB1bm5l Y2Vzc2FyeQotICAgICAgICB3b3JrLiAgSWYgc2V0IHRvIDxsaXRlcmFsPm9mZjwvbGl0ZXJh bD4sIG9ubHkgdGhlIGZpbmFsIGJ5dGUgaXMgd3JpdHRlbgotICAgICAgICB3aGVuIHRoZSBm aWxlIGlzIGNyZWF0ZWQgc28gdGhhdCBpdCBoYXMgdGhlIGV4cGVjdGVkIHNpemUuCi0gICAg ICAgPC9wYXJhPgotICAgICAgPC9saXN0aXRlbT4KLSAgICAgPC92YXJsaXN0ZW50cnk+Ci0K LSAgICAgPHZhcmxpc3RlbnRyeSBpZD0iZ3VjLXdhbC1yZWN5Y2xlIiB4cmVmbGFiZWw9Indh bF9yZWN5Y2xlIj4KLSAgICAgIDx0ZXJtPjx2YXJuYW1lPndhbF9yZWN5Y2xlPC92YXJuYW1l PiAoPHR5cGU+Ym9vbGVhbjwvdHlwZT4pCi0gICAgICA8aW5kZXh0ZXJtPgotICAgICAgIDxw cmltYXJ5Pjx2YXJuYW1lPndhbF9yZWN5Y2xlPC92YXJuYW1lPiBjb25maWd1cmF0aW9uIHBh cmFtZXRlcjwvcHJpbWFyeT4KLSAgICAgIDwvaW5kZXh0ZXJtPgotICAgICAgPC90ZXJtPgot ICAgICAgPGxpc3RpdGVtPgotICAgICAgIDxwYXJhPgotICAgICAgICBJZiBzZXQgdG8gPGxp dGVyYWw+b248L2xpdGVyYWw+ICh0aGUgZGVmYXVsdCksIHRoaXMgb3B0aW9uIGNhdXNlcyBX QUwKLSAgICAgICAgZmlsZXMgdG8gYmUgcmVjeWNsZWQgYnkgcmVuYW1pbmcgdGhlbSwgYXZv aWRpbmcgdGhlIG5lZWQgdG8gY3JlYXRlIG5ldwotICAgICAgICBvbmVzLiAgT24gQ09XIGZp bGUgc3lzdGVtcywgaXQgbWF5IGJlIGZhc3RlciB0byBjcmVhdGUgbmV3IG9uZXMsIHNvIHRo ZQotICAgICAgICBvcHRpb24gaXMgZ2l2ZW4gdG8gZGlzYWJsZSB0aGlzIGJlaGF2aW9yLgot ICAgICAgIDwvcGFyYT4KLSAgICAgIDwvbGlzdGl0ZW0+Ci0gICAgIDwvdmFybGlzdGVudHJ5 PgotCiAgICAgICA8dmFybGlzdGVudHJ5IGlkPSJndWMtbWF4LXNsb3Qtd2FsLWtlZXAtc2l6 ZSIgeHJlZmxhYmVsPSJtYXhfc2xvdF93YWxfa2VlcF9zaXplIj4KICAgICAgICA8dGVybT48 dmFybmFtZT5tYXhfc2xvdF93YWxfa2VlcF9zaXplPC92YXJuYW1lPiAoPHR5cGU+aW50ZWdl cjwvdHlwZT4pCiAgICAgICAgPGluZGV4dGVybT4K --------------603780304767152326C58CF6--