Message-ID: <ee89f8397eeceee32fc773e0a235d7f222988096.camel@cybertec.at>
Subject: Re: Second paragraph a little bit misleading
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Bruce Momjian <bruce@momjian.us>
Cc: afripowered@gmail.com, pgsql-docs@lists.postgresql.org
Date: Fri, 21 Feb 2025 13:42:09 +0100
In-Reply-To: <Z7hq4D_QMwR85DOO@momjian.us>
References: <173928241056.707.3989867022954178032@wrigleys.postgresql.org>
	 <Z7dak8fwxwezBhyh@momjian.us>
	 <43db6e44e5bc8c6f22eb439c8256f1e1bc135cf7.camel@cybertec.at>
	 <Z7hq4D_QMwR85DOO@momjian.us>
User-Agent: Evolution 3.54.3 (3.54.3-1.fc41) 
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/ee89f8397eeceee32fc773e0a235d7f222988096.camel%40cybertec.at>
Precedence: bulk

On Fri, 2025-02-21 at 07:00 -0500, Bruce Momjian wrote:
> > > diff --git a/doc/src/sgml/wal.sgml b/doc/src/sgml/wal.sgml
> > > index 52b5b8f793b..705ca682777 100644
> > > --- a/doc/src/sgml/wal.sgml
> > > +++ b/doc/src/sgml/wal.sgml
> > > @@ -246,7 +246,7 @@
> > > =C2=A0=C2=A0=C2=A0 </para>
> > > =C2=A0=20
> > > =C2=A0=C2=A0=C2=A0 <para>
> > > -=C2=A0=C2=A0 Checksums are normally enabled when the cluster is init=
ialized using <link
> > > +=C2=A0=C2=A0 Checksums can be enabled when the cluster is initialize=
d using <link
> > > =C2=A0=C2=A0=C2=A0=C2=A0 linkend=3D"app-initdb-data-checksums"><appli=
cation>initdb</application></link>.
> > > =C2=A0=C2=A0=C2=A0=C2=A0 They can also be enabled or disabled at a la=
ter time as an offline
> > > =C2=A0=C2=A0=C2=A0=C2=A0 operation. Data checksums are enabled or dis=
abled at the full cluster
> >=20
> > The change looks good for the back branches, but the default has change=
d
> > in v18: now checksums are the default.=C2=A0 So "can be enabled" doesn'=
t sound
> > right for v18.=C2=A0 I'd leave "are normally enabled" in HEAD.
>=20
> Yes, I was confused about that too, but I think we changed the code for
> the development branch and if we decide to keep the new default, we will
> change the docs later.=C2=A0 I didn't want to interfere with that.

Hmpf.  The documentation should always be in sync with the code, right?
So I think it should be left alone in HEAD, and if the checksum change
gets reverted, your patch should be applied to HEAD.

Yours,
Laurenz Albe

--=20

*E-Mail Disclaimer*
Der Inhalt dieser E-Mail ist ausschliesslich fuer den=20
bezeichneten Adressaten bestimmt. Wenn Sie nicht der vorgesehene Adressat=
=20
dieser E-Mail oder dessen Vertreter sein sollten, so beachten Sie bitte,=20
dass jede Form der Kenntnisnahme, Veroeffentlichung, Vervielfaeltigung oder=
=20
Weitergabe des Inhalts dieser E-Mail unzulaessig ist. Wir bitten Sie, sich=
=20
in diesem Fall mit dem Absender der E-Mail in Verbindung zu setzen.

*CONFIDENTIALITY NOTICE & DISCLAIMER
*This message and any attachment are=20
confidential and may be privileged or otherwise protected from disclosure=
=20
and solely for the use of the person(s) or entity to whom it is intended.=
=20
If you have received this message in error and are not the intended=20
recipient, please notify the sender immediately and delete this message and=
=20
any attachment from your system. If you are not the intended recipient, be=
=20
advised that any use of this message is prohibited and may be unlawful, and=
=20
you must not copy this message or attachment or disclose the contents to=20
any other person.