From: "Bradley DeJong" <bpd0018@gmail.com>
To: "Tatsuo Ishii" <ishii@sraoss.co.jp>, pgsql-docs@postgresql.org
Subject: Re: Enhancing protocol.sgml
Date: Fri, 24 Aug 2018 15:43:28 +0000
Message-Id: <embf269241-6c21-44d2-8c0e-629656d3b112@dolphin>
In-Reply-To: <20180728.125153.1487613390757751788.t-ishii@sraoss.co.jp>
References: <20180728.125153.1487613390757751788.t-ishii@sraoss.co.jp>
Reply-To: "Bradley DeJong" <bpd0018@gmail.com>
User-Agent: eM_Client/7.1.33101.0
Mime-Version: 1.0
Content-Type: multipart/mixed;
 boundary="------=_MB0222E265-56DC-463F-8B3F-F959BC779C3F"
Precedence: bulk

--------=_MB0222E265-56DC-463F-8B3F-F959BC779C3F
Content-Type: multipart/alternative;
 boundary="------=_MB3D65C7A9-C421-40B0-8C83-E8FD55398BF0"

--------=_MB3D65C7A9-C421-40B0-8C83-E8FD55398BF0
Content-Type: text/plain; format=flowed; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 2018-07-27, Tatsuo Ishii wrote ...
 > ... I think this should be mentioned in protocol.sgml as well. ...

I agree. It is already mentioned as one of the differences between v2=20
and v3 but an implementer should not need to read that section if they=20
are only implementing v3. (I know I've never looked at it before.)

Using protocol.diff as a base, I changed the phrasing to be more=20
prescriptive for v3 protocol implementers (don't send a final line, be=20
prepared to receive a final line), changed passive voice to active voice=20
and fixed one COPYData -> CopyData capitalization.

I also called this out in the description of the CopyData message format=20
because that is where the termination line would be transmitted.
--------=_MB3D65C7A9-C421-40B0-8C83-E8FD55398BF0
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: quoted-printable

<html><head><style><![CDATA[#x115f80de43fb45faa9c12df5d9f673e4 blockquote.c=
ite2{
	margin-left:5px;
	margin-right:0px;
	padding-left:10px;
	padding-right:0px;
	border-left-width:1px;
	border-left-style:solid;
	border-left-color:#CCC;
	margin-top:3px;
	padding-top:0px;
}
#x115f80de43fb45faa9c12df5d9f673e4{
	font-family:Tahoma;
	font-size:12pt;
}]]></style>
<meta http-equiv=3D"Content-Type" content=3D"text/html;charset=3Dutf-8" />
<style id=3D"css_styles" type=3D"text/css"><!--blockquote.cite { margin-lef=
t: 5px; margin-right: 0px; padding-left: 10px; padding-right:0px; border-le=
ft: 1px solid #cccccc }
blockquote.cite2 {margin-left: 5px; margin-right: 0px; padding-left: 10px;=
 padding-right:0px; border-left: 1px solid #cccccc; margin-top: 3px; padding=
-top: 0px; }
a img { border: 0px; }
li[style=3D'text-align: center;'], li[style=3D'text-align: right;'] {  list=
-style-position: inside;}
body { font-family: Tahoma; font-size: 12pt;   }--></style></head>
<body><div>On 2018-07-27, Tatsuo Ishii wrote ...</div><div>&gt; ...=C2=A0I=
 think this should be mentioned in protocol.sgml as well. ...</div><div><br=
 /></div><div>I agree. It is already mentioned as one of the differences bet=
ween v2 and v3 but an implementer should not need to read that section if t=
hey are only implementing v3. (I know I've never looked at it before.)</div=
><div><br /></div><div>Using protocol.diff as a base, I changed the phrasin=
g to be more prescriptive for v3 protocol implementers (don't send a final=
 line, be prepared to receive a final line), changed passive voice to active =
voice and fixed one COPYData -&gt; CopyData capitalization.</div>
<div><br /></div><div>I also called this out in the description of the Copy=
Data message format because that is where the termination line would be tra=
nsmitted.</div><div id=3D"xd24de45e365f48f" class=3D"plain"><blockquote cit=
e=3D"20180728.125153.1487613390757751788.t-ishii@sraoss.co.jp" type=3D"cite=
" class=3D"cite2"><tt style=3D"word-wrap:break-word">
</tt></blockquote></div>


</body></html>
--------=_MB3D65C7A9-C421-40B0-8C83-E8FD55398BF0--

--------=_MB0222E265-56DC-463F-8B3F-F959BC779C3F
Content-Type: application/octet-stream; name=protocol.v2.patch
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename=protocol.v2.patch

ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9wcm90b2NvbC5zZ21sIGIvZG9jL3NyYy9zZ21sL3By
b3RvY29sLnNnbWwKaW5kZXggZjBiMjE0NTIwOC4uZmRkOWM1Y2YwYyAxMDA2NDQKLS0tIGEvZG9j
L3NyYy9zZ21sL3Byb3RvY29sLnNnbWwKKysrIGIvZG9jL3NyYy9zZ21sL3Byb3RvY29sLnNnbWwK
QEAgLTExNTQsNiArMTE1NCwyMiBAQCBTRUxDVCAxLzA7CiAgICAgKGlmIHN1Y2Nlc3NmdWwpIG9y
IEVycm9yUmVzcG9uc2UgKGlmIG5vdCkuCiAgICA8L3BhcmE+CiAKKyAgIDxub3RlPgorICAgICAg
PHBhcmE+CisgICAgICBWZXJzaW9uIDIuMCBvZiB0aGUgPHByb2R1Y3RuYW1lPlBvc3RncmVTUUw8
L3Byb2R1Y3RuYW1lPiBwcm90b2NvbAorICAgICAgcmVxdWlyZXMgdGhlIHNlbmRlciB0byB0ZXJt
aW5hdGUgdGhlIDxjb21tYW5kPkNPUFk8L2NvbW1hbmQ+IGRhdGEgc3RyZWFtCisgICAgICB3aXRo
IGEgZmluYWwgPGxpdGVyYWw+XC48L2xpdGVyYWw+IGxpbmUuIEluIHRoZSB2My4wIHByb3RvY29s
LCB1c2Ugb2YKKyAgICAgIHRoZSB0ZXJtaW5hdGluZyBsaW5lIGlzIGRlcHJlY2F0ZWQgYW5kIG1h
ZGUgb3B0aW9uYWwuIFRoZSAzLjAKKyAgICAgIHByb3RvY29sIG5vdyBlbmNhcHN1bGF0ZXMgdGhl
IGRhdGEgaW50byBDb3B5RGF0YSBtZXNzYWdlcyBhbmQgdGVybWluYXRlcworICAgICAgdGhlIGRh
dGEgc3RyZWFtIHdpdGggYSBDb3B5RG9uZSBtZXNzYWdlLiBJZiB0aGUgdGVybWluYXRpbmcgbGlu
ZSBpcworICAgICAgcHJlc2VudCwgaXQgbXVzdCBhcHBlYXIgaW1tZWRpYXRlbHkgYmVmb3JlIHRo
ZSBDb3B5RG9uZSBtZXNzYWdlLgorICAgICAgQW55IGNvZGUgdGhhdCBmdWxseSBpbXBsZW1lbnRz
IHZlcnNpb24gMy4wIG9mIHRoZSBjb3B5LWluL2NvcHktb3V0CisgICAgICBzdWItcHJvdG9jb2wg
c2hvdWxkIG5vdCBzZW5kIHRoZSB0ZXJtaW5hdGluZyBsaW5lIGJ1dCBtdXN0IGFsbG93CisgICAg
ICBmb3IgdGhlIHRlcm1pbmF0aW5nIGxpbmUgd2hlbiByZWNlaXZpbmcgPGNvbW1hbmQ+Q09QWTwv
Y29tbWFuZD4KKyAgICAgIGRhdGEuIFRoZSB0ZXJtaW5hdGluZyBsaW5lIHdpbGwgYmUgcmVtb3Zl
ZCBmcm9tIGEgZnV0dXJlIHByb3RvY29sIHZlcnNpb24uCisgICAgICA8L3BhcmE+CisgICA8L25v
dGU+CisKICAgIDxwYXJhPgogICAgIEluIHRoZSBldmVudCBvZiBhIGJhY2tlbmQtZGV0ZWN0ZWQg
ZXJyb3IgZHVyaW5nIGNvcHktaW4gbW9kZSAoaW5jbHVkaW5nCiAgICAgcmVjZWlwdCBvZiBhIENv
cHlGYWlsIG1lc3NhZ2UpLCB0aGUgYmFja2VuZCB3aWxsIGlzc3VlIGFuIEVycm9yUmVzcG9uc2UK
QEAgLTM5MjgsNyArMzk0NCwxMSBAQCBDb3B5RGF0YSAoRiAmYW1wOyBCKQogICAgICAgICAgICAg
ICAgIERhdGEgdGhhdCBmb3JtcyBwYXJ0IG9mIGEgPGNvbW1hbmQ+Q09QWTwvY29tbWFuZD4gZGF0
YSBzdHJlYW0uICBNZXNzYWdlcyBzZW50CiAgICAgICAgICAgICAgICAgZnJvbSB0aGUgYmFja2Vu
ZCB3aWxsIGFsd2F5cyBjb3JyZXNwb25kIHRvIHNpbmdsZSBkYXRhIHJvd3MsCiAgICAgICAgICAg
ICAgICAgYnV0IG1lc3NhZ2VzIHNlbnQgYnkgZnJvbnRlbmRzIG1pZ2h0IGRpdmlkZSB0aGUgZGF0
YSBzdHJlYW0KLSAgICAgICAgICAgICAgICBhcmJpdHJhcmlseS4KKyAgICAgICAgICAgICAgICBh
cmJpdHJhcmlseS4gVGhlIGxhc3QgQ29weURhdGEgbWVzc2FnZSBiZWZvcmUgQ29weURvbmUgbWF5
IGNvbnRhaW4gYW4gb3B0aW9uYWwKKyAgICAgICAgICAgICAgICB0ZXJtaW5hdGlvbiBsaW5lIGNv
bnRhaW5pbmcgPGxpdGVyYWw+XC48L2xpdGVyYWw+LiBUaGlzIHRlcm1pbmF0aW9uIGxpbmUgaXMK
KyAgICAgICAgICAgICAgICBhIGhvbGRvdmVyIGZyb20gdGhlIFYyLjAgcHJvdG9jb2wuIEl0IGlz
IG5vdCBwYXJ0IG9mIHRoZSBkYXRhIHN0cmVhbSBhbmQgc2hvdWxkCisgICAgICAgICAgICAgICAg
YmUgaWdub3JlZC4gU2VlIHRoZSBkZXNjcmlwdGlvbiBvZiB0aGUgPGNvbW1hbmQ+Q09QWTwvY29t
bWFuZD4gc3ViLXByb3RvY29sCisgICAgICAgICAgICAgICAgbWVzc2FnZSBmbG93IGZvciBtb3Jl
IGRldGFpbC4KIDwvcGFyYT4KIDwvbGlzdGl0ZW0+CiA8L3Zhcmxpc3RlbnRyeT4K
--------=_MB0222E265-56DC-463F-8B3F-F959BC779C3F--