Feedback-ID: ie0a040ee:Fastmail
Message-ID: <f0f2ecbc-3237-4cf7-8fb3-b8eb2b039bf8@eisentraut.org>
Date: Thu, 18 Jan 2024 15:54:26 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: create table explicitly mention that unique|primary key
 constraint will create an
Content-Language: en-US
To: Laurenz Albe <laurenz.albe@cybertec.at>,
 jian he <jian.universality@gmail.com>, pgsql-docs@lists.postgresql.org
References: 
 <CACJufxFG682tYcP9aH_F-jrqq5End8MHZR77zcp1=DUrEsSu1Q@mail.gmail.com>
 <24f01200b651ff87311ae0f46b99eaf91fc3ec43.camel@cybertec.at>
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <24f01200b651ff87311ae0f46b99eaf91fc3ec43.camel@cybertec.at>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/f0f2ecbc-3237-4cf7-8fb3-b8eb2b039bf8%40eisentraut.org>
Precedence: bulk

On 27.11.23 03:30, Laurenz Albe wrote:
> True; I don't find it documented that all objects in pg_class share a
> namespace and that constraints are implemented by indexes of the same
> name.  But I think that the first part is a property of schemas and had
> better be documented there.

It is documented prominently on the CREATE INDEX reference page.  We 
could document it in more places, of course.  I find the specific change 
proposal for ddl.sgml a bit weird, though, because this is a very 
introductory section, and you are referring people to pg_class (what is 
that?!?) for details.  If we want to put something there, it should 
respect the order in which that chapter introduces concepts.

The changes on create_table.sgml seem ok.  Although I had actually 
expected that the system applies the find-a-unique-name routine rather 
than taking the constraint name for the index name unaltered.

Perhaps taking the create_table.sgml changes and combination with the 
existing text on CREATE INDEX is sufficient.