Subject: Re: Fix the example in the document of file-fdw
To: Michael Paquier <michael@paquier.xyz>,
 btkatsuragiyu <btkatsuragiyu@oss.nttdata.com>
Cc: pgsql-docs@postgresql.org
References: <0cd5a9ebbec58bb16fd3f6eb20e401d9@oss.nttdata.com>
 <3b42a115-ebc9-d800-f51f-b5bf7a84201b@oss.nttdata.com>
 <20200914050716.GC2183@paquier.xyz>
 <fccb0907a64286534b7077f0ea8ddae5@oss.nttdata.com>
 <20200914075621.GD2183@paquier.xyz>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
Message-ID: <f296e0d4-226d-bbcd-0d82-b80e5c58062a@oss.nttdata.com>
Date: Tue, 15 Sep 2020 16:43:39 +0900
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0)
 Gecko/20100101 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20200914075621.GD2183@paquier.xyz>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2020/09/14 16:56, Michael Paquier wrote:
> On Mon, Sep 14, 2020 at 04:10:03PM +0900, btkatsuragiyu wrote:
>> However, I think showing complete DDL including SERVER pglog and OPTIONS
>> would be helpful
>> to users who are not familiar with this feature.

Agreed.


> Yeah, this could be mentioned on the doc page for file_fdw with an
> extra sentence, but I agree that it is more complex to understand that
> than a simple copy-paste from the doc itself.

So ISTM our consensus is to apply the proposed patch.
Barring any objection, I will do that.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION