Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1pSBHO-0007cw-TM
	for pgsql-docs@arkaria.postgresql.org; Wed, 15 Feb 2023 06:28:34 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1pSBHN-00084o-O0
	for pgsql-docs@arkaria.postgresql.org; Wed, 15 Feb 2023 06:28:33 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <katsuragiy@oss.nttdata.com>)
	id 1pSBHN-00084f-GB
	for pgsql-docs@lists.postgresql.org; Wed, 15 Feb 2023 06:28:33 +0000
Received: from oss.nttdata.com ([49.212.34.109])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <katsuragiy@oss.nttdata.com>)
	id 1pSBHK-00075Q-Jq
	for pgsql-docs@lists.postgresql.org; Wed, 15 Feb 2023 06:28:32 +0000
Received: from oss.nttdata.com (localhost [127.0.0.1])
	by oss.nttdata.com (Postfix) with ESMTPA id 7602760855;
	Wed, 15 Feb 2023 15:28:26 +0900 (JST)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.7 at oss.nttdata.com
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Wed, 15 Feb 2023 15:28:26 +0900
From: Katsuragi Yuta <katsuragiy@oss.nttdata.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: meson doc: Is "-Dtap-tests" a typo?
In-Reply-To: <Y+xjFxRHr9WDFQrw@paquier.xyz>
References: <cff4558e170be78d8fd64ed45edbe1cb@oss.nttdata.com>
 <Y+xjFxRHr9WDFQrw@paquier.xyz>
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <f3195e160e49aecf6af02090eea97e46@oss.nttdata.com>
X-Sender: katsuragiy@oss.nttdata.com
List-Id: <pgsql-docs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-docs@lists.postgresql.org>
List-Owner: <mailto:pgsql-docs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-docs>
Archived-At: 
 <https://www.postgresql.org/message-id/f3195e160e49aecf6af02090eea97e46%40oss.nttdata.com>
Precedence: bulk

On 2023-02-15 13:44, Michael Paquier wrote:
> On Tue, Feb 14, 2023 at 09:06:13AM +0000, Katsuragi Yuta wrote:
>> The parameter name "-Dtap-tests" in the meson's doc seems to be a 
>> typo.
>> I think "-Dtap_tests" is the correct name.  Attached patch fixes that.
>> 
>> I got an unknown options error by using "-Dtap-tests=enabled". 
>> However,
>> meson_options.txt told me the correct name was "-Dtap_tests".
> 
>       <varlistentry id="configure-tap-tests-meson">
> -      <term><option>-Dtap-tests={ auto | enabled | disabled 
> }</option></term>
> +      <term><option>-Dtap_tests={ auto | enabled | disabled 
> }</option></term>
> 
> And meson.build refers to the same term, as of "tap_tests":
> # Check whether tap tests are enabled or not
> tap_tests_enabled = false
> tapopt = get_option('tap_tests')
> 
> So you are indeed right.  Nice catch.  Will fix.
> --
> Michael

Thank you!

regards,

-- 
Katsuragi Yuta
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION