Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wW5iy-002Nuk-1S for pgsql-docs@arkaria.postgresql.org; Sun, 07 Jun 2026 05:07:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wW5iv-00GwYh-2B for pgsql-docs@arkaria.postgresql.org; Sun, 07 Jun 2026 05:07:01 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wW5iv-00GwYY-1M for pgsql-docs@lists.postgresql.org; Sun, 07 Jun 2026 05:07:01 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wW5it-00000001Uce-2lA9 for pgsql-docs@lists.postgresql.org; Sun, 07 Jun 2026 05:07:00 +0000 Received: by mail-wm1-x342.google.com with SMTP id 5b1f17b1804b1-490c1915793so17251905e9.2 for ; Sat, 06 Jun 2026 22:06:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cybertec.at; s=google; t=1780808817; x=1781413617; darn=lists.postgresql.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=rsARxkjn3cyQdj582wIoSvY+R+bCXNdNu3CcMeHXsZw=; b=beZNyaXjpQeQIQftuXiC0HkdriIITN7Nt8R4YiZ3CLkjkcp9v78uK/uA0hpAOtMo1a tCHQyTbqQ1BYWwSEKpaJSL4rm1fhJjywB4iVoKcrULR8+cj79wAK8m69H0DVt3JsuZ4g YRSapHcc7tO5krJKcTYnSE9sSogX0BgaxkfKsuuhgLUl9uwOzdmlGFoumRfcerjgNRUc lfOQO4/kYNvNhSQvjlGNaavBNfrjFpPu/BHyowYrPr/+q3JgiM7Tp2QELB50adHmGRCI aou3IgDCNpKBxjid7DZzoOyxMDMnkqsz8qVOPG6pak5yiTJXH8OGUyEKcCy7WzH2UW0e Zobg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780808817; x=1781413617; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rsARxkjn3cyQdj582wIoSvY+R+bCXNdNu3CcMeHXsZw=; b=MGByIqTzwLshW2otT53vcfbEd42b3dftAPGC3M4UOs6SJz02HOnRWmZoIwv/BNThbm VzMAWPAhotboz1KhycTkn8VhxLC3bkI/sTQHfqPME++fH9cKhjVTbxMDOx/+QFFCVOVe bz9sShMpmqxEOpkxS6kDAYgW9hXnK0KAEJlKa/tnz+WXHSBEuuRwkI85AVWJGG5mLMtQ vd86Il/e13iIUYJOR0uguqecc0gCKr3YqjvACfdHO6l8Qoj7CjySIjuoT+Xm/KituNuI PkDc89HiXvSoflKyUjKG46WUQB8BA8hWdSm3oviXa9LsMi2muVYaG5mWgScxQRy1n46b hhRA== X-Forwarded-Encrypted: i=1; AFNElJ8smF/+5NJeXVDi13/04qpofF8R7S7DUMMne2SFGGUo5Q6/qxdzlEz8JJM3cejq4HaiJWO48H7+71QL@lists.postgresql.org X-Gm-Message-State: AOJu0YzGahM/G2NuQtZR5fz65lDsB/okvoppLgTz2rlIFFxBmFQBw0fz TBHsU35zVnmoHcC0taYH0FZI1XAKVZmvp5Siy1azCaiRz9gpjSTaforlLQ19Z4Srnfg= X-Gm-Gg: Acq92OH1qrhv0ebdtx8r14wZleb0ZChm77v9/ok/1GIHs1V/WhoOJBJGyLuZE/cH0xt yYOGe4IhVpDKQZOy7l9yKyN27eJdJNk21y3AbBTV8OHt0+SpPy6VlFLru0Ne5egtOdAfAHDoZ5d ORnDyfQhR7jPj+72tn/Y6t45aX/f+j07gBSq4dUxb9eSSvxs6ZxhPY/NykeaIFa9XBCRW5KcgVq YL0Yeg6mDchRib3mfRqY5ezZKEaFk6eiVUvUTzV5CksVLP08nlReZ8/gsdD72Kb+pcYmsXcvzu4 /x2TTogkUH9VpkjrLWXAMzXbDiv1Pxrf8MDzJf6s5UIbI7LZSlephLZ+sekGyPwoV26b/PgxiPl 2PPymRzCQneTZUNCcH1tFO89RxvaAwfC8S/3hcSA3mlnrr0OJheK+fsO7XLH+7srr3+x11kHjbz wrJTYeNKz2yblAXJNk97JRjsM5VqU7dg9jf8h8gFrphWq8Xw49NellGDT9Xld7XJFy X-Received: by 2002:a05:600c:1d14:b0:48a:58ae:9938 with SMTP id 5b1f17b1804b1-490c260471cmr172741655e9.19.1780808817005; Sat, 06 Jun 2026 22:06:57 -0700 (PDT) Received: from laurenz.albe-K4N0CV00F97414D ([2001:871:270:21f:fc97:3ffd:7f89:d662]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490bda4fd52sm265371315e9.0.2026.06.06.22.06.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jun 2026 22:06:56 -0700 (PDT) Message-ID: Subject: Re: [PATCH] Correct the version sent in protocol negotiation From: Laurenz Albe To: Ning Sun , pgsql-docs@lists.postgresql.org Date: Sun, 07 Jun 2026 07:06:55 +0200 In-Reply-To: <065b1b54-dc4a-4a29-919d-76f89ce96532@gmail.com> References: <065b1b54-dc4a-4a29-919d-76f89ce96532@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Sun, 2026-06-07 at 10:00 +0800, Ning Sun wrote: > Our protocol doc describes protocol negotiation message will send latest= =20 > minor version. However that field is a 4-byte one. The actual=20 > implementation sends full version including the major part: >=20 > The patch included just clarifies this behavior by removing "minor" from= =20 > "newest minor version". To my understanding, the "minor version" is the entire version *including* the last number, like 18.4 (and not only .4). In this, I seem to be in agreement with https://www.postgresql.org/support/versioning/ To me, removing the "minor" makes the text less clear. If we change that at all, perhaps a wording like "the full version, including the minor release" would remove any ambiguity. Yours, Laurenz Albe