pg.ddx.io  pgsql-docs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
links to functions-window
2+ messages / 2 participants
[nested] [flat]

* links to functions-window
@ 2010-07-01 17:56 Erik Rijkers <er@xs4all.nl>
  2010-07-03 02:59 ` Re: links to functions-window Robert Haas <robertmhaas@gmail.com>
  0 siblings, 1 reply; 2+ messages in thread

From: Erik Rijkers @ 2010-07-01 17:56 UTC (permalink / raw)
  To: pgsql-docs

There is a curious oversight in the windows documentation, where
the several window pages are not linking to the functions-window
(where the actual functions are enumerated).

That makes it easy to overlook for instance, a function like row_number() (not mentioned in other
examples).

I think at least the below three links should be added.

Erik Rijkers



inline patch 1: advanced.sgml, syntax.sgml, queries.sgml (+5/-2 lines) download inline-1.patch--- advanced.sgml.orig 2010-07-01 19:02:56.000000000 +0200 +++ advanced.sgml 2010-07-01 19:05:07.000000000 +0200 @@ -554,6 +554,7 @@ <para> More details about window functions can be found in <xref linkend="syntax-window-functions">, + <xref linkend="functions-window">, <xref linkend="queries-window">, and the <xref linkend="sql-select"> reference page. </para> --- syntax.sgml.orig 2010-07-01 19:06:08.000000000 +0200 +++ syntax.sgml 2010-07-01 19:06:42.000000000 +0200 @@ -1761,7 +1761,8 @@ <para> More information about window functions can be found in - <xref linkend="tutorial-window"> and + <xref linkend="tutorial-window">, + <xref linkend="functions-window">, <xref linkend="queries-window">. </para> </sect2> --- queries.sgml.orig 2010-07-01 19:46:32.000000000 +0200 +++ queries.sgml 2010-07-01 19:47:16.000000000 +0200 @@ -979,7 +979,8 @@ <para> If the query contains any window functions (see - <xref linkend="tutorial-window"> and + <xref linkend="tutorial-window">, + <xref linkend="functions-window"> and <xref linkend="syntax-window-functions">), these functions are evaluated after any grouping, aggregation, and <literal>HAVING</> filtering is performed. That is, if the query uses any aggregates, <literal>GROUP
^ permalink raw reply [nested|flat] 2+ messages in thread

* Re: links to functions-window
  2010-07-01 17:56 links to functions-window Erik Rijkers <er@xs4all.nl>
@ 2010-07-03 02:59 ` Robert Haas <robertmhaas@gmail.com>
  0 siblings, 0 replies; 2+ messages in thread

From: Robert Haas @ 2010-07-03 02:59 UTC (permalink / raw)
  To: Erik Rijkers <er@xs4all.nl>; +Cc: pgsql-docs

On Thu, Jul 1, 2010 at 1:56 PM, Erik Rijkers <er@xs4all.nl> wrote:
> There is a curious oversight in the windows documentation, where
> the several window pages are not linking to the functions-window
> (where the actual functions are enumerated).
>
> That makes it easy to overlook for instance, a function like row_number() (not mentioned in other
> examples).
>
> I think at least the below three links should be added.

Committed.  FWIW, it's easier to extract the patch (at least for me)
if you attach it rather than including it in the body of the email.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2010-07-03 02:59 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2010-07-01 17:56 links to functions-window Erik Rijkers <er@xs4all.nl>
2010-07-03 02:59 ` Robert Haas <robertmhaas@gmail.com>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox