Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1uPu9o-000Y6E-2X
	for pgsql-docs@arkaria.postgresql.org; Fri, 13 Jun 2025 02:28:40 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1uPu9k-000FQ5-Ji
	for pgsql-docs@arkaria.postgresql.org; Fri, 13 Jun 2025 02:28:37 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <masao.fujii@oss.nttdata.com>)
	id 1uPu9k-000FPx-CD
	for pgsql-docs@lists.postgresql.org; Fri, 13 Jun 2025 02:28:37 +0000
Received: from oss.nttdata.com ([49.212.34.109])
	by makus.postgresql.org with smtp (Exim 4.96)
	(envelope-from <masao.fujii@oss.nttdata.com>)
	id 1uPu9i-001i7B-10
	for pgsql-docs@lists.postgresql.org;
	Fri, 13 Jun 2025 02:28:36 +0000
Received: from [192.168.11.9] (p1696134-ipoe.ipoe.ocn.ne.jp [118.0.93.133])
	by oss.nttdata.com (Postfix) with ESMTPSA id 7829A609D9;
	Fri, 13 Jun 2025 11:28:29 +0900 (JST)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.11 at oss.nttdata.com
Message-ID: <f58eb77f-0d8f-4f58-bed2-a100bd7e0814@oss.nttdata.com>
Date: Fri, 13 Jun 2025 11:28:28 +0900
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Clarify VACUUM FULL exclusion in total_vacuum_time docs
To: Robert Treat <rob@xzilla.net>,
 "David G. Johnston" <david.g.johnston@gmail.com>
Cc: "pgsql-docs@lists.postgresql.org" <pgsql-docs@lists.postgresql.org>
References: <2ac375d1-591b-4f1b-a2af-f24335567866@oss.nttdata.com>
 <CAKFQuwYgErraNuAUme-6dSwmwNSSStC8SL7560Qy2sAtUG5J+Q@mail.gmail.com>
 <CABV9wwMs4g9nq-fKy=fFqU-rQUf6fiCqJg4_+MkqOnJE1n2TBA@mail.gmail.com>
Content-Language: en-US
From: Fujii Masao <masao.fujii@oss.nttdata.com>
In-Reply-To: 
 <CABV9wwMs4g9nq-fKy=fFqU-rQUf6fiCqJg4_+MkqOnJE1n2TBA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
List-Id: <pgsql-docs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-docs@lists.postgresql.org>
List-Owner: <mailto:pgsql-docs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-docs>
Archived-At: 
 <https://www.postgresql.org/message-id/f58eb77f-0d8f-4f58-bed2-a100bd7e0814%40oss.nttdata.com>
Precedence: bulk



On 2025/06/07 0:13, Robert Treat wrote:
> On Fri, Jun 6, 2025 at 9:57=E2=80=AFAM David G. Johnston
> <david.g.johnston@gmail.com> wrote:
>> On Friday, June 6, 2025, Fujii Masao <masao.fujii@oss.nttdata.com> wro=
te:
>>>
>>> Hi,
>>>
>>> Since last_vacuum and vacuum_count in pg_stat_all_tables explicitly m=
ention
>>> that they don't include VACUUM FULL ("not counting VACUUM FULL"), I t=
hink
>>> we should add the same clarification to the description of total_vacu=
um_time.
>>> This field also excludes VACUUM FULL, and without this note, users mi=
ght
>>> mistakenly think the time spent on VACUUM FULL is included. Thought?
>>>
>>>          <structfield>total_vacuum_time</structfield> <type>double pr=
ecision</type>
>>>         </para>
>>>         <para>
>>> -       Total time this table has been manually vacuumed, in millisec=
onds.
>>> +       Total time this table has been manually vacuumed, in millisec=
onds
>>> +       (not counting <command>VACUUM FULL</command>).
>>>          (This includes the time spent sleeping due to cost-based del=
ays.)
>>>         </para></entry>
>>>        </row>
>>
>>
>>   Makes sense.  Our naming this table rewrite vacuum full does confuse=
 people into thinking it is related to vacuum.
>>
>=20
> +1 for this change,

Thanks both for the review!


> but I think we should also update
> n_ins_since_vacuum as well, no?

I didn't update n_ins_since_vacuum since it's mainly used by autovacuum r=
ather
than end users, and there haven't been any complaints about the current
description so far. That said, I don't have a strong opinion either way,
so I'm fine with making the change if others think it's worthwhile.

Regards,

--=20
Fujii Masao
NTT DATA Japan Corporation