Content-Type: multipart/mixed; boundary="------------FVThpR0s8xO0W0O0zHxmSnyr"
Message-ID: <f84cbf9e-cf4b-a9eb-9667-5fadd913d5ca@gmail.com>
Date: Tue, 15 Mar 2022 23:21:41 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: pg_dump shared locks documentation
To: Tom Lane <tgl@sss.pgh.pa.us>, Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-docs@lists.postgresql.org
References: <202203151506.55cjea5lmp2l@alvherre.pgsql>
 <324244.1647359709@sss.pgh.pa.us>
From: Florin Irion <irionr@gmail.com>
In-Reply-To: <324244.1647359709@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/f84cbf9e-cf4b-a9eb-9667-5fadd913d5ca%40gmail.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------FVThpR0s8xO0W0O0zHxmSnyr
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 15/03/22 16:55, Tom Lane wrote:
> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
>> This might be a bit excessive to have in the main text.  What about
>> adding a footnote to point out the exact lock level that is meant, with
>> a link to the server doc page that explains each lock level?
> 
> I dunno how well <footnote> will render in man-page format.
> How about just inserting a parenthetical remark at the first usage?
> 
> ... leader process requests shared locks (ACCESS SHARE) on the ...
> 
> Possibly we could make the "ACCESS SHARE" be a <link> without causing
> problems in man format.
> 
> 			regards, tom lane

Makes sense.
I tried the footnote and in fact, it doesn't render well in the man page. It just adds a blank line(at least how I tried it).

So, I made the link to ACCESS SHARE, pointing to section 13.3.1. "Table-Level Locks" , was this what you had in mind? 

V2 attached. 

Thank you for looking into this.
Florin Irion
--------------FVThpR0s8xO0W0O0zHxmSnyr
Content-Type: text/plain; charset=UTF-8;
 name="v2-0001-Specify-correctly-the-locks-pg_dump-takes.patch"
Content-Disposition: attachment;
 filename="v2-0001-Specify-correctly-the-locks-pg_dump-takes.patch"
Content-Transfer-Encoding: base64

RnJvbSAxM2M1N2U1MjE4YjYwNWJkOWQxMDFlOTY2YjhlZGI0ODZkYWFjMDkxIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBGbG9yaW4gSXJpb24gPGZsb3Jpbi5pcmlvbkBlbnRl
cnByaXNlZGIuY29tPgpEYXRlOiBUdWUsIDE1IE1hciAyMDIyIDIyOjQzOjM0ICswMTAwClN1
YmplY3Q6IFtQQVRDSCB2Ml0gU3BlY2lmeSBjb3JyZWN0bHkgdGhlIGxvY2tzIHBnX2R1bXAg
dGFrZXMKClRoZSBwZ19kdW1wIGxlYWRlciBhbmQgd29ya2VyIHByb2Nlc3NlcyB0YWtlIGBB
Y2Nlc3NTaGFyZUxvY2tgcywKY2xhcmlmeSBpdCBpbiB0aGUgZG9jcyBzbyB0aGF0IGl0IGNh
biBub3QgYmUgbWlzdW5kZXJzdG9vZCB3aXRoCmBTaGFyZUxvY2tgcy4KLS0tCiBkb2Mvc3Jj
L3NnbWwvcmVmL3BnX2R1bXAuc2dtbCB8IDQgKystLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5z
ZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kb2Mvc3JjL3NnbWwv
cmVmL3BnX2R1bXAuc2dtbCBiL2RvYy9zcmMvc2dtbC9yZWYvcGdfZHVtcC5zZ21sCmluZGV4
IDJmMDA0MmZkOTYuLjA3ZWRkNDU5Y2YgMTAwNjQ0Ci0tLSBhL2RvYy9zcmMvc2dtbC9yZWYv
cGdfZHVtcC5zZ21sCisrKyBiL2RvYy9zcmMvc2dtbC9yZWYvcGdfZHVtcC5zZ21sCkBAIC0z
NzIsOCArMzcyLDggQEAgUG9zdGdyZVNRTCBkb2N1bWVudGF0aW9uCiAgICAgICAgPHBhcmE+
CiAgICAgICAgIFJlcXVlc3RpbmcgZXhjbHVzaXZlIGxvY2tzIG9uIGRhdGFiYXNlIG9iamVj
dHMgd2hpbGUgcnVubmluZyBhIHBhcmFsbGVsIGR1bXAgY291bGQKICAgICAgICAgY2F1c2Ug
dGhlIGR1bXAgdG8gZmFpbC4gVGhlIHJlYXNvbiBpcyB0aGF0IHRoZSA8YXBwbGljYXRpb24+
cGdfZHVtcDwvYXBwbGljYXRpb24+IGxlYWRlciBwcm9jZXNzCi0gICAgICAgIHJlcXVlc3Rz
IHNoYXJlZCBsb2NrcyBvbiB0aGUgb2JqZWN0cyB0aGF0IHRoZSB3b3JrZXIgcHJvY2Vzc2Vz
IGFyZSBnb2luZyB0byBkdW1wIGxhdGVyCi0gICAgICAgIGluIG9yZGVyIHRvCisgICAgICAg
IHJlcXVlc3RzIHNoYXJlZCBsb2NrcyAoPGxpbmsgbGlua2VuZD0ibG9ja2luZy10YWJsZXMi
PkFDQ0VTUyBTSEFSRTwvbGluaz4pIG9uIHRoZQorICAgICAgICBvYmplY3RzIHRoYXQgdGhl
IHdvcmtlciBwcm9jZXNzZXMgYXJlIGdvaW5nIHRvIGR1bXAgbGF0ZXIgaW4gb3JkZXIgdG8K
ICAgICAgICAgbWFrZSBzdXJlIHRoYXQgbm9ib2R5IGRlbGV0ZXMgdGhlbSBhbmQgbWFrZXMg
dGhlbSBnbyBhd2F5IHdoaWxlIHRoZSBkdW1wIGlzIHJ1bm5pbmcuCiAgICAgICAgIElmIGFu
b3RoZXIgY2xpZW50IHRoZW4gcmVxdWVzdHMgYW4gZXhjbHVzaXZlIGxvY2sgb24gYSB0YWJs
ZSwgdGhhdCBsb2NrIHdpbGwgbm90IGJlCiAgICAgICAgIGdyYW50ZWQgYnV0IHdpbGwgYmUg
cXVldWVkIHdhaXRpbmcgZm9yIHRoZSBzaGFyZWQgbG9jayBvZiB0aGUgbGVhZGVyIHByb2Nl
c3MgdG8gYmUKLS0gCjIuMzQuMAoK

--------------FVThpR0s8xO0W0O0zHxmSnyr--