Content-Type: multipart/mixed; boundary="------------eTfxHyMUwKeVjTX25xvZ621S"
Message-ID: <f86cd84f-a6a3-4451-bae7-5cca9e63b06d@oss.nttdata.com>
Date: Wed, 18 Jun 2025 14:34:55 +0900
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: pgsql-docs@lists.postgresql.org
From: Fujii Masao <masao.fujii@oss.nttdata.com>
Subject: Fix inaccurate mention of index comments in CREATE FOREIGN TABLE docs
Archived-At: 
 <https://www.postgresql.org/message-id/f86cd84f-a6a3-4451-bae7-5cca9e63b06d%40oss.nttdata.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------eTfxHyMUwKeVjTX25xvZ621S
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

Commit 302cf157592 added support for LIKE in CREATE FOREIGN TABLE.
In this feature, since indexes are not created for foreign tables,
comments on indexes are not copied either.

However, the CREATE FOREIGN TABLE docs incorrectly states that
index comments are copied when using INCLUDING COMMENTS, as shown below:

     ------------------------------
     INCLUDING COMMENTS
     Comments for the copied columns, constraints, and indexes will be copied.
     ------------------------------

This isn't accurate for foreign tables, so we should remove the mention
of indexes. Patch attached.

Regards,

-- 
Fujii Masao
NTT DATA Japan Corporation

--------------eTfxHyMUwKeVjTX25xvZ621S
Content-Type: text/plain; charset=UTF-8;
 name="v1-0001-doc-Fix-incorrect-description-of-INCLUDING-COMMEN.patch"
Content-Disposition: attachment;
 filename*0="v1-0001-doc-Fix-incorrect-description-of-INCLUDING-COMMEN.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSBlNmEwMjNiNTZmNzkwYzk5OTU0NjNkNzVlNjEwMWU1ZWFmNDllOThiIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBNYXNhbyA8ZnVqaWlAcG9zdGdyZXNxbC5v
cmc+CkRhdGU6IFdlZCwgMTggSnVuIDIwMjUgMTM6NTY6MTQgKzA5MDAKU3ViamVjdDogW1BB
VENIIHYxXSBkb2M6IEZpeCBpbmNvcnJlY3QgZGVzY3JpcHRpb24gb2YgSU5DTFVESU5HIENP
TU1FTlRTIGluCiBDUkVBVEUgRk9SRUlHTiBUQUJMRS4KCkNvbW1pdCAzMDJjZjE1NzU5MiBh
ZGRlZCBzdXBwb3J0IGZvciBMSUtFIGluIENSRUFURSBGT1JFSUdOIFRBQkxFLgpJbiB0aGlz
IGZlYXR1cmUsIHNpbmNlIGluZGV4ZXMgYXJlIG5vdCBjcmVhdGVkIGZvciBmb3JlaWduIHRh
YmxlcywKY29tbWVudHMgb24gaW5kZXhlcyBhcmUgbm90IGNvcGllZCBlaXRoZXIuCgpIb3dl
dmVyLCB0aGUgZG9jdW1lbnRhdGlvbiBpbmNvcnJlY3RseSBzdGF0ZWQgdGhhdCBpbmRleCBj
b21tZW50cwp3b3VsZCBiZSBjb3BpZWQgd2hlbiB1c2luZyBJTkNMVURJTkcgQ09NTUVOVFMu
IFRoaXMgY29tbWl0CmNvcnJlY3RzIHRoYXQgYnkgcmVtb3ZpbmcgdGhlIG1lbnRpb24gb2Yg
aW5kZXggY29tbWVudHMuCi0tLQogZG9jL3NyYy9zZ21sL3JlZi9jcmVhdGVfZm9yZWlnbl90
YWJsZS5zZ21sIHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRl
bGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvZG9jL3NyYy9zZ21sL3JlZi9jcmVhdGVfZm9yZWln
bl90YWJsZS5zZ21sIGIvZG9jL3NyYy9zZ21sL3JlZi9jcmVhdGVfZm9yZWlnbl90YWJsZS5z
Z21sCmluZGV4IGQwODgzNGFjOWQyLi4wMDlmYTQ2NTMyYiAxMDA2NDQKLS0tIGEvZG9jL3Ny
Yy9zZ21sL3JlZi9jcmVhdGVfZm9yZWlnbl90YWJsZS5zZ21sCisrKyBiL2RvYy9zcmMvc2dt
bC9yZWYvY3JlYXRlX2ZvcmVpZ25fdGFibGUuc2dtbApAQCAtMjMyLDcgKzIzMiw3IEBAIFdJ
VEggKCBNT0RVTFVTIDxyZXBsYWNlYWJsZSBjbGFzcz0icGFyYW1ldGVyIj5udW1lcmljX2xp
dGVyYWw8L3JlcGxhY2VhYmxlPiwgUkVNCiAgICAgICAgIDx0ZXJtPjxsaXRlcmFsPklOQ0xV
RElORyBDT01NRU5UUzwvbGl0ZXJhbD48L3Rlcm0+CiAgICAgICAgIDxsaXN0aXRlbT4KICAg
ICAgICAgIDxwYXJhPgotICAgICAgICAgIENvbW1lbnRzIGZvciB0aGUgY29waWVkIGNvbHVt
bnMsIGNvbnN0cmFpbnRzLCBhbmQgaW5kZXhlcyB3aWxsIGJlCisgICAgICAgICAgQ29tbWVu
dHMgZm9yIHRoZSBjb3BpZWQgY29sdW1ucyBhbmQgY29uc3RyYWludHMgd2lsbCBiZQogICAg
ICAgICAgIGNvcGllZC4gIFRoZSBkZWZhdWx0IGJlaGF2aW9yIGlzIHRvIGV4Y2x1ZGUgY29t
bWVudHMsIHJlc3VsdGluZyBpbgogICAgICAgICAgIHRoZSBjb3BpZWQgY29sdW1ucyBhbmQg
Y29uc3RyYWludHMgaW4gdGhlIG5ldyB0YWJsZSBoYXZpbmcgbm8KICAgICAgICAgICBjb21t
ZW50cy4KLS0gCjIuNDkuMAoK

--------------eTfxHyMUwKeVjTX25xvZ621S--