Message-ID: <f882f36c5a00d72d4c4fc6e05d1881bf3b903e20.camel@cybertec.at>
Subject: Re: terminology in example
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Bruce Momjian <bruce@momjian.us>, taf1@cornell.edu,
	pgsql-docs@lists.postgresql.org
Date: Wed, 01 Apr 2020 08:37:30 +0200
In-Reply-To: <20200331231013.GJ17676@momjian.us>
References: <158506544539.679.2278386310645558048@wrigleys.postgresql.org>
	 <20200324174141.GC4828@momjian.us> <20200331231013.GJ17676@momjian.us>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.32.5 (3.32.5-1.fc30) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 2020-03-31 at 19:10 -0400, Bruce Momjian wrote:

> The attached patch fixes the problem.  The regression tests also have
> many mentions of "altitude."  Should those be changed too?

I don't think that is necessary.
Names don't matter in the regression tests.

> --- a/doc/src/sgml/advanced.sgml
> +++ b/doc/src/sgml/advanced.sgml
> @@ -585,20 +585,20 @@ SELECT sum(salary) OVER w, avg(salary) OVER w
>  CREATE TABLE capitals (
>    name       text,
>    population real,
> -  altitude   int,    -- (in ft)
> +  elevation   int,    -- (in ft)
>    state      char(2)
>  );
>  
>  CREATE TABLE non_capitals (
>    name       text,
>    population real,
> -  altitude   int     -- (in ft)
> +  elevation   int     -- (in ft)
>  );
> 

> @@ -612,7 +612,7 @@ CREATE VIEW cities AS
>  CREATE TABLE cities (
>    name       text,
>    population real,
> -  altitude   int     -- (in ft)
> +  elevation   int     -- (in ft)
>  );

The "int" should be aligned with the rest (delete one space).

Yours,
Laurenz Albe