public inbox for [email protected]  

help / color / mirror / Atom feed

From: Erik Wienhold <[email protected]>
To: Hoda Salim <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] docs: document N'...' national character string literal syntax
Date: Wed, 4 Feb 2026 01:24:34 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAAGT0i+SrExi4LVf-gQ4t9XY724pVRxEvOZft4B0uUs-gDuYHA@mail.gmail.com>
References: <CAAGT0iKc1Fq=mmK99fMd8O+QGZfCAqzx3bOWBcci6fO8SjLGtQ@mail.gmail.com>
	<[email protected]>
	<CAAGT0i+SrExi4LVf-gQ4t9XY724pVRxEvOZft4B0uUs-gDuYHA@mail.gmail.com>

On 2026-02-02 21:04 +0100, Hoda Salim wrote:
> > nchar is an alias of bpchar.  There's no cast to char behind the scenes
> > since that would truncate the string:
> >
> >         select n'foo', 'foo'::character;
> >          bpchar | bpchar
> >         --------+--------
> >          foo    | f
> >         (1 row)
> 
> Thank you for catching this! I verified the behavior and updated the
> documentation to correctly state that N'...' is equivalent to a bpchar
> literal.

Thanks!  The text looks good now.  But please fix the indentation of the
second paragraph (should be one space per level).  Your first patch was
correct in that regard.

> > Should we also mention the nchar alias in [4]?
> > [4] https://www.postgresql.org/docs/current/datatype-character.html
> 
> I'm happy to add that in a v3 if you think it belongs in this patch.
> I wasn't sure if it would be preferred separately or together.

I'd prefer a single patch with both changes to have an atomic change.
But in the end it's up to the committer, not me.

--
Erik Wienhold

view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] docs: document N'...' national character string literal syntax
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox