Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xEX38-000000019ET-3p8K for pgsql-docs@arkaria.postgresql.org; Wed, 07 Oct 2026 19:11:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.98.2) (envelope-from ) id 1xEX37-00000008HRQ-3OWi for pgsql-docs@arkaria.postgresql.org; Wed, 07 Oct 2026 19:11:33 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xEX05-00000008GLX-1eis for pgsql-docs@lists.postgresql.org; Wed, 07 Oct 2026 19:08:25 +0000 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1xEX03-00000000rrV-1nLw for pgsql-docs@lists.postgresql.org; Wed, 07 Oct 2026 19:08:24 +0000 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-4a021c809e3so22200215e9.0 for ; Wed, 07 Oct 2026 12:08:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cybertec.at; s=google; t=1791400102; x=1792004902; darn=lists.postgresql.org; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to:content-type; bh=DL/Jo5b1t2goRI9cr5KTQZF9XenEYNX9Ijv041HWGn8=; b=hy+ar7m0xY1QaPO0tdJxwWlPexDTM5BAbE2jSH8vaT7Fp9BLbF/MbazkdIXbmnBmSQ d9xNJvkawlateKj5pjmnU6r5ztF7s4hMr5XT/npYXIMh/SfpxONCR3JMJR0hI0NE89of +PalWp4Jo3JVOpejG8YwJcoZgSICcK7bXwJU1+rYzkm2uT9otMwlKAtHdpLYti/ftORU akHAd4SNQoJMbkl0P+P5nIB8OsPqub8kG33fs3aAnD6Wlvv1ydyHAHmthkQOJjeh6ZHe qXv6QA3EW0jnPfS9tx7YzJOnOk+s1WssdHJo2krugfJf2byn8Oz5vXWIBLl2a8hWXFnR nx2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791400102; x=1792004902; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=DL/Jo5b1t2goRI9cr5KTQZF9XenEYNX9Ijv041HWGn8=; b=x0whql8VwufkyT9pT88m5ODD6uO4myM84CwA3wdgKylZJtX8M9wvJqHEP5DvrG4Lf7 odLhLSRS9mTxBIZYlQBM4kavvGL+YJmjSJSwjfNHVaY1wMygIN0g1Xic/rY1VNMCOev4 5+B7jONwFWFOdXmlxvivminFbPg/2jVWg++HzLNZXQPpVbpM+4+EIBSBCFshRtr0Nhke sa3wOY6DIjV0vaSyZ0ES/ojMH1whMnnwZAgLKjsMhNgIugIW55RnUy+MYFxGfQ2OsaCV IfvLkgxjOFlFiRARYqCsRbNyeY5yhOWAX842wEHUKHvuwpd6misWRj/rJddHQ5kyGZcN CBtQ== X-Gm-Message-State: AFuF++nW2o6PoUlldLGanRvLDVNJE80KFEielEpQc++L/S30EWdm0f1G pR5O210R7nlUZhwd9drZ4M91zO4P7hQUTj9QyKnbaKb9Tc2atgXJzlwtL/sxcXaXjFLsRoVLryc JGYFZqIE= X-Gm-Gg: AYBFou3PIs1qCW2tjbIyffvGxnK4N+oylMAwSsbZzPlHy4YJrk+HUGIYGc5X+EJol1t L3Cws1SJ+KirKvYzFyweVoB4XS09mK25k0kWu92Bj02Hj7SvTtnN9LiYIb8FSNXs6auDnGgcF4H IoR7El+WGt7onzRjdqVsln4ONAUAY/hAIxcP3uCHjn0D2+x6qVzwAwKxylCrCIYqsXrYvav66MP y5t/A/Mzimll/Z1Ok5Z+P8jiD/0RQmmBUKZD0lMJDQrZb/zM3E8p9yCutBSFoOgJAaBPsKitsWl 2fQrT0VRDRJGsPoGsJAfucZCbyz9nXkrPViGF9pFYt96pG9u968yCOz2oXRw8lYvzEoiPvVBOrP q9UhOyV5kaFhK/Zw3rHS6pSzQMrmTomi5xLbbpkVLGgLMjw24fqwuju4r6CogA+6OfYghsei6OL 9LLThaNUgG9pwmyZzp6YeGwW9yFkrMEP78btQubg5PRYR5dztpGJ8Sv+LPv+j1x9By6mviq/mCc pf7Oj94wmyHUZ3TW2wyEpBhCjRG18BY6Q5RsmopSQ== X-Received: by 2002:a05:600c:4fcb:b0:49f:bd3c:bc1b with SMTP id 5b1f17b1804b1-4a1804557f1mr48953585e9.22.1791400101935; Wed, 07 Oct 2026 12:08:21 -0700 (PDT) Received: from laurenz.albe-K4N0CV00F97414D ([2001:871:270:b677:677f:591c:a18a:2956]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a17fc4a588sm70957435e9.1.2026.10.07.12.08.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Oct 2026 12:08:21 -0700 (PDT) Message-ID: Subject: Re: Fixes for create subscription page From: Laurenz Albe To: Thom Brown Cc: pgsql-docs@lists.postgresql.org Date: Wed, 07 Oct 2026 21:08:20 +0200 In-Reply-To: References: <5e6ffc6412da6fb68718a4c123e875f8d423dcad.camel@cybertec.at> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.2 (3.60.2-2.fc44) MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, 2026-10-07 at 17:03 +0100, Thom Brown wrote: > On Wed, 7 Oct 2026 at 15:32, Laurenz Albe wrot= e: > >=20 > > On Wed, 2026-10-07 at 11:58 +0100, Thom Brown wrote: > > > I was looking through the new options for create subscription, and > > > found issues with some of the text, so I reviewed the whole page. > > > Attached are my proposed changes. > >=20 > > > --- a/doc/src/sgml/ref/create_subscription.sgml > > > +++ b/doc/src/sgml/ref/create_subscription.sgml > >=20 > > > > > > Since no connection is made when this option is > > > - false, no tables and sequences are subs= cribed. To > > > + false, no tables or sequences are subsc= ribed. To > >=20 > > Hm. I think "and" would be the better conjunction here (although "or" > > is not really wrong). >=20 > I think an "or" after a "no" doesn't read well. I think, in order to > use "and", it would have to read "tables and sequences are not > subscribed." That sounds good to me. > > > send and receive functions will be transferred in binary. = Note that > > > the initial synchronization requires all data types to hav= e binary > > > - send and receive functions, otherwise the synchronization = will fail > > > + send and receive functions, otherwise synchronization will= fail > > > (see for more about sen= d/receive > > > functions). This parameter has no effect for sequences. > >=20 > > My feeling is that the article is correct here (disclaimer: I am not > > a native speaker). >=20 > I guess if we're specifically referring to the initial synchronisation > earlier in the sentence, my correction isn't an improvement. Good, we are in agreement then. > > > - overall system performance. This option provides minimal = performance > > > + overall system performance. This option incurs minimal pe= rformance > > > overhead when applied appropriately. The following scenar= ios illustrate > >=20 > > I see your point, although you could argue that "minimal performance ov= erhead" > > is a feature, and you provide a feature rather than incur it. > > How about "provides reduced performance overhead"? >=20 > I'm not keen on "providing" any overhead, but we could just be > completely neutral about it: >=20 > "This option has minimal performance overhead when applied appropriately.= " Well, picking nits, the option itself *is* not a minimal overhead, using it= causes minimal overhead. So perhaps If this option is applied appropriately, the performance overhead will be= minimal.=20 > > > c. Read-Only Subscribers: > > > In configurations involving single or multiple publisher = nodes > > > performing concurrent write operations, read-only subscri= ber nodes may > > > - replicate changes without seeing a performance impact if = it does index > > > - scan. However, if the subscriber is impacted due to repli= cation lag or > > > - scan performance (say due to sequential scans), it needs = to follow one > > > + replicate changes without performance degradation if perf= orming index > > > + scans. However, if the subscriber is affected due to repl= ication lag or > > > + scan performance (e.g. due to sequential scans), it needs= to follow one > > > of the two previous strategies to distribute the workload= on the > > > subscriber. > >=20 > > Your change clearly is an improvement (the original was grammatically w= rong). > > But "subscriber nodes may replicate changes without performance degrada= tion > > if performing index scans" still feels less than perfect. Shouldn't it= be > > "when performing index scans" or "when they perform index scans" or - e= ven > > better - "during index scans"? >=20 > Yeah, fair enough. I would avoid "during index scans" as it makes it > about timing. But "when performing index scans" sounds right. Great. > > > See for details = on > > > how to configure access control between the subscription and the > > > - publication instance. > > > + publisher instance. > >=20 > > I think you should be consistent: "between the subscriber and the publi= sher > > instance". But perhaps it would be best to retain the original, becaus= e > > "publication" and "subscription" are the names of the PostgreSQL object= s > > involved. How about "between the database with the subscription and th= e > > database with the publication"? >=20 > Yeah, point taken. Maybe leave that as it is. Fine! Yours, Laurenz Albe