Content-Type: multipart/mixed; boundary="------------hml0mTDmqimTj2g6tjdrq9UK"
Message-ID: <fe405123-9cae-4f16-81c0-4e73bec93b81@postgrespro.ru>
Date: Thu, 26 Oct 2023 13:31:07 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Example 43.6. A PL/pgSQL Trigger Function for Maintaining a
 Summary Table
Content-Language: en-US
To: Daniel Gustafsson <daniel@yesql.se>
Cc: pgsql-docs@lists.postgresql.org
References: <70f74895-8512-4b2f-8617-2ac0ebcd2e87@postgrespro.ru>
 <99AC5F34-FDB6-42A8-867A-CF97F0707F9B@yesql.se>
From: Maxim Yablokov <m.yablokov@postgrespro.ru>
Organization: Postgres Professional
In-Reply-To: <99AC5F34-FDB6-42A8-867A-CF97F0707F9B@yesql.se>
Archived-At: 
 <https://www.postgresql.org/message-id/fe405123-9cae-4f16-81c0-4e73bec93b81%40postgrespro.ru>
Precedence: bulk

This is a multi-part message in MIME format.
--------------hml0mTDmqimTj2g6tjdrq9UK
Content-Type: multipart/alternative;
 boundary="------------jgP7gYpBsHOVE5qYDVUaJHl0"

--------------jgP7gYpBsHOVE5qYDVUaJHl0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

I believe that the attached patch should fix this problem. Please have a 
look.

26.10.2023 12:29, Daniel Gustafsson пишет:
>> On 26 Oct 2023, at 09:33, Maxim Yablokov<m.yablokov@postgrespro.ru>  wrote:
>> Example 43.6 on the pagehttps://www.postgresql.org/docs/16/plpgsql-trigger.html  has two tables called main. But it seems that the table time_dimension is not used any further, it's a bit strange for one of main tables of the example. Am I missing something, or should this example be extended (or reduced)?
> Interesting catch, time_dimension has been unused since introduced with commit
> a294726bc1d (in 2005), and the archives doesn't provide any further insights.
> While I don't have access to the book referred to for the example, we don't
> expect our readers to either so it seems to me that we could remove it from the
> example to avoid risk of confusion. Would you like to propose a patch for this?
>
> --
> Daniel Gustafsson
>
-- 
Best regards,
Maxim Yablokov
Technical writer-translator
Postgres Professional <https://postgrespro.com/>
--------------jgP7gYpBsHOVE5qYDVUaJHl0
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p>I believe that the attached patch should fix this problem. Please
      have a look.<br>
    </p>
    <div class="moz-cite-prefix">26.10.2023 12:29, Daniel Gustafsson
      пишет:<br>
    </div>
    <blockquote type="cite"
      cite="mid:99AC5F34-FDB6-42A8-867A-CF97F0707F9B@yesql.se">
      <blockquote type="cite">
        <pre class="moz-quote-pre" wrap="">On 26 Oct 2023, at 09:33, Maxim Yablokov <a class="moz-txt-link-rfc2396E" href="mailto:m.yablokov@postgrespro.ru">&lt;m.yablokov@postgrespro.ru&gt;</a> wrote:
</pre>
      </blockquote>
      <pre class="moz-quote-pre" wrap="">
</pre>
      <blockquote type="cite">
        <pre class="moz-quote-pre" wrap="">Example 43.6 on the page <a class="moz-txt-link-freetext" href="https://www.postgresql.org/docs/16/plpgsql-trigger.html">https://www.postgresql.org/docs/16/plpgsql-trigger.html</a> has two tables called main. But it seems that the table time_dimension is not used any further, it's a bit strange for one of main tables of the example. Am I missing something, or should this example be extended (or reduced)?
</pre>
      </blockquote>
      <pre class="moz-quote-pre" wrap="">
Interesting catch, time_dimension has been unused since introduced with commit
a294726bc1d (in 2005), and the archives doesn't provide any further insights.
While I don't have access to the book referred to for the example, we don't
expect our readers to either so it seems to me that we could remove it from the
example to avoid risk of confusion. Would you like to propose a patch for this?

--
Daniel Gustafsson

</pre>
    </blockquote>
    <div class="moz-signature">-- <br>
      Best regards,<br>
      Maxim Yablokov<br>
      Technical writer-translator<br>
      <a href="https://postgrespro.com/">Postgres Professional</a></div>
  </body>
</html>

--------------jgP7gYpBsHOVE5qYDVUaJHl0--

--------------hml0mTDmqimTj2g6tjdrq9UK
Content-Type: text/x-patch; charset=UTF-8; name="plpgsql-trigger.patch"
Content-Disposition: attachment; filename="plpgsql-trigger.patch"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9wbHBnc3FsLnNnbWwgYi9kb2Mvc3JjL3NnbWwv
cGxwZ3NxbC5zZ21sCmluZGV4IDgzZjg2N2Y5MWQyLi43MTAzYWIwM2I3NCAxMDA2NDQKLS0t
IGEvZG9jL3NyYy9zZ21sL3BscGdzcWwuc2dtbAorKysgYi9kb2Mvc3JjL3NnbWwvcGxwZ3Nx
bC5zZ21sCkBAIC00NDQ5LDE4ICs0NDQ5LDggQEAgSU5TVEVBRCBPRiBJTlNFUlQgT1IgVVBE
QVRFIE9SIERFTEVURSBPTiBlbXBfdmlldwogCiA8cHJvZ3JhbWxpc3Rpbmc+CiAtLQotLS0g
TWFpbiB0YWJsZXMgLSB0aW1lIGRpbWVuc2lvbiBhbmQgc2FsZXMgZmFjdC4KKy0tIE1haW4g
dGFibGUgLSBzYWxlcyBmYWN0LgogLS0KLUNSRUFURSBUQUJMRSB0aW1lX2RpbWVuc2lvbiAo
Ci0gICAgdGltZV9rZXkgICAgICAgICAgICAgICAgICAgIGludGVnZXIgTk9UIE5VTEwsCi0g
ICAgZGF5X29mX3dlZWsgICAgICAgICAgICAgICAgIGludGVnZXIgTk9UIE5VTEwsCi0gICAg
ZGF5X29mX21vbnRoICAgICAgICAgICAgICAgIGludGVnZXIgTk9UIE5VTEwsCi0gICAgbW9u
dGggICAgICAgICAgICAgICAgICAgICAgIGludGVnZXIgTk9UIE5VTEwsCi0gICAgcXVhcnRl
ciAgICAgICAgICAgICAgICAgICAgIGludGVnZXIgTk9UIE5VTEwsCi0gICAgeWVhciAgICAg
ICAgICAgICAgICAgICAgICAgIGludGVnZXIgTk9UIE5VTEwKLSk7Ci1DUkVBVEUgVU5JUVVF
IElOREVYIHRpbWVfZGltZW5zaW9uX2tleSBPTiB0aW1lX2RpbWVuc2lvbih0aW1lX2tleSk7
Ci0KIENSRUFURSBUQUJMRSBzYWxlc19mYWN0ICgKICAgICB0aW1lX2tleSAgICAgICAgICAg
ICAgICAgICAgaW50ZWdlciBOT1QgTlVMTCwKICAgICBwcm9kdWN0X2tleSAgICAgICAgICAg
ICAgICAgaW50ZWdlciBOT1QgTlVMTCwK

--------------hml0mTDmqimTj2g6tjdrq9UK--