Received: from maia.hub.org (maia-2.hub.org [200.46.204.251]) by mail.postgresql.org (Postfix) with ESMTP id E3B391337B84 for ; Tue, 26 Oct 2010 22:24:06 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.251]) (amavisd-maia, port 10024) with ESMTP id 91604-05 for ; Wed, 27 Oct 2010 01:23:59 +0000 (UTC) Received: from news.hub.org (news.hub.org [200.46.204.72]) by mail.postgresql.org (Postfix) with ESMTP id 4CF5E1337B7A for ; Tue, 26 Oct 2010 22:23:59 -0300 (ADT) Received: from news.hub.org (news.hub.org [200.46.204.72]) by news.hub.org (8.14.4/8.14.4) with ESMTP id o9R1Nwln044986 for ; Tue, 26 Oct 2010 22:23:58 -0300 (ADT) (envelope-from news@news.hub.org) Received: (from news@localhost) by news.hub.org (8.14.4/8.14.4/Submit) id o9R1BgjD019417 for pgsql-docs@postgresql.org; Tue, 26 Oct 2010 22:11:42 -0300 (ADT) (envelope-from news) From: ljb X-Newsgroups: pgsql.docs Subject: Re: [GENERAL] Gripe: bytea_output default => data corruption Date: Wed, 27 Oct 2010 01:11:42 +0000 (UTC) Organization: Hub.Org Networking Services Lines: 14 Message-ID: References: <201010212342.o9LNgEu17871@momjian.us> <8604.1288048729@sss.pgh.pa.us> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Complaints-To: usenet@news.hub.org User-Agent: slrn/0.9.9p1 (Linux) To: pgsql-docs@postgresql.org X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0.79 tagged_above=-5 required=5 tests=BAYES_50=0.8, T_RP_MATCHES_RCVD=-0.01 X-Spam-Level: X-Archive-Number: 201010/53 X-Sequence-Number: 6194 tgl@sss.pgh.pa.us wrote: > I think we should simply remove the description of *how* the escaping is > performed, and state only that the function produces a suitably escaped > literal string. Anything else is not future-proof, and could someday > break the way this wording did. Perhaps it would be best to remove escaping details here. But the description of PQescapeBytea() might need to be rewritten, too. Without describing exactly what PQescapeByteaConn() does, it is hard to understand what PQescapeBytea() does not do, and why it therefore "might give the wrong results". I think the actual function behavior should be documented somewhere. Even though it might change again.