From: Dimitri Fontaine <dfontaine@hi-media.com>
To: Simon Riggs <simon@2ndQuadrant.com>
Cc: Fujii Masao <masao.fujii@gmail.com>,
	Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Re: [COMMITTERS] pgsql: Make standby server continuously retry
	restoring the next WAL
Organization: Hi-Media
References: <20100127152751.3B2047541B9@cvs.postgresql.org>
	<4B73F678.8070109@enterprisedb.com> <1265891248.7341.1346.camel@ebony>
	<4B73FB99.4080403@enterprisedb.com> <1265893599.7341.1454.camel@ebony>
	<877hqjc2kk.fsf@hi-media-techno.com>
	<1265896250.7341.1627.camel@ebony> <4B740C6C.3010607@enterprisedb.com>
	<1265897834.7341.1714.camel@ebony> <4B7412BE.5030605@enterprisedb.com>
	<3f0b79eb1002112138n61a3258fg9986e50751d44ea0@mail.gmail.com>
	<1265979080.7341.3679.camel@ebony> <1265985269.7341.4105.camel@ebony>
User-Mail-Address: dfontaine@hi-media.com
Date: Fri, 12 Feb 2010 18:25:02 +0100
In-Reply-To: <1265985269.7341.4105.camel@ebony> (Simon Riggs's message of
	"Fri, 12 Feb 2010 14:34:29 +0000")
Message-ID: <m2ljeywemp.fsf@hi-media.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (darwin)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

Simon Riggs <simon@2ndQuadrant.com> writes:
> Attached patch implements pg_standby for use as an
> archive_cleanup_command, reusing existing code with new -a option.
>
> Happy to add the archive_cleanup_command into main server as well, if
> you like. Won't take long.

Would it be possible to have the server do the cleanup (and the cp for
that matter) on its own or use a script?

Either have archive_cleanup = on and either an commented out (empty)
archive_cleanup_command and the same for the restore_command, or a
special magic value, like 'postgresql' to activate the internal one.

This way we have both a zero config working default setup and the
flexibility to adapt to any archiving solution our user might already be
using.

A default archive_command would be nice too. Like you give it a
directory name or a rsync path and it does the basic right thing.

I'm not sure my detailed approach is the right one, but the birdview is
to have the simple case really simple to setup, and the complex cases
still possible. Default included archive, restore and cleanup commands
would be awesome.

Oh, and the basic simple case actually is with a remote standby. Without
NFS or the like, no shared mount point for archiving. 

Regards,
-- 
dim