public inbox for [email protected]
help / color / mirror / Atom feed[PATCH] DOCS: Fix inconsistent text description punctuation in UPDATE FOR PORTION OF
3+ messages / 2 participants
[nested] [flat]
* [PATCH] DOCS: Fix inconsistent text description punctuation in UPDATE FOR PORTION OF
@ 2026-05-25 09:32 =?utf-8?B?WC1NQU4=?= <[email protected]>
0 siblings, 1 reply; 3+ messages in thread
From: =?utf-8?B?WC1NQU4=?= @ 2026-05-25 09:32 UTC (permalink / raw)
To: =?utf-8?B?cGdzcWwtZG9jcw==?= <[email protected]>; +Cc: =?utf-8?B?5oiR6Ieq5bex55qE6YKu566x?= <[email protected]>
Hi,
I noticed an inconsistency in the documentation between UPDATE and DELETE
commands regarding the FOR PORTION OF clause description.
In doc/src/sgml/ref/update.sgml (line 169), the description reads:
"must be in the form ( portion ) where portion is an expression..."
In doc/src/sgml/ref/delete.sgml (line 166), it reads:
"must be in the form ( portion ), where portion is an expression..."
The UPDATE documentation misses a comma before "where" that DELETE has.
For consistency, add the comma to the UPDATE documentation to match DELETE.
I have recompiled the documentation and verified that
share/doc/postgresql/html/sql-update.html and
share/doc/postgresql/html/sql-delete.html are now consistent.
Best regards,
Zizhuan Liu
Attachments:
[application/octet-stream] 0001-DOCS-Fix-missing-comma-in-UPDATE-FOR-PORTION-OF-text.patch (1.1K, 3-0001-DOCS-Fix-missing-comma-in-UPDATE-FOR-PORTION-OF-text.patch)
download | inline diff:
From 83f6a5e79706ffd126ce98f3417b93231598afcb Mon Sep 17 00:00:00 2001
From: Zizhuan Liu <[email protected]>
Date: Mon, 25 May 2026 16:59:41 +0800
Subject: [PATCH] DOCS : Fix missing comma in UPDATE FOR PORTION OF text
description
---
doc/src/sgml/ref/update.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/ref/update.sgml b/doc/src/sgml/ref/update.sgml
index 92c12c3..dd57bea 100644
--- a/doc/src/sgml/ref/update.sgml
+++ b/doc/src/sgml/ref/update.sgml
@@ -166,7 +166,7 @@ UPDATE [ ONLY ] <replaceable class="parameter">table_name</replaceable> [ * ]
class="parameter">start_time</replaceable> <literal>TO</literal>
<replaceable class="parameter">end_time</replaceable>. Otherwise, it
must be in the form <literal>(</literal><replaceable
- class="parameter">portion</replaceable><literal>)</literal> where
+ class="parameter">portion</replaceable><literal>)</literal>, where
<replaceable class="parameter">portion</replaceable> is an expression
that yields a value of the same type as <replaceable
class="parameter">range_column_name</replaceable>.
--
2.43.0
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: [PATCH] DOCS: Fix inconsistent text description punctuation in UPDATE FOR PORTION OF
@ 2026-05-25 23:21 Paul A Jungwirth <[email protected]>
parent: =?utf-8?B?WC1NQU4=?= <[email protected]>
0 siblings, 1 reply; 3+ messages in thread
From: Paul A Jungwirth @ 2026-05-25 23:21 UTC (permalink / raw)
To: X-MAN <[email protected]>; +Cc: pgsql-docs <[email protected]>
On Mon, May 25, 2026 at 2:33 AM X-MAN <[email protected]> wrote:
>
> Hi,
> I noticed an inconsistency in the documentation between UPDATE and DELETE
> commands regarding the FOR PORTION OF clause description.
>
> In doc/src/sgml/ref/update.sgml (line 169), the description reads:
> "must be in the form ( portion ) where portion is an expression..."
>
> In doc/src/sgml/ref/delete.sgml (line 166), it reads:
> "must be in the form ( portion ), where portion is an expression..."
Thanks for the patch! This looks good to me.
Yours,
--
Paul ~{:-)
[email protected]
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: [PATCH] DOCS: Fix inconsistent text description punctuation in UPDATE FOR PORTION OF
@ 2026-05-26 01:59 =?utf-8?B?WC1NQU4=?= <[email protected]>
parent: Paul A Jungwirth <[email protected]>
0 siblings, 0 replies; 3+ messages in thread
From: =?utf-8?B?WC1NQU4=?= @ 2026-05-26 01:59 UTC (permalink / raw)
To: =?utf-8?B?UGF1bCBBIEp1bmd3aXJ0aA==?= <[email protected]>; +Cc: =?utf-8?B?cGdzcWwtZG9jcw==?= <[email protected]>
>On Mon, May 25, 2026 at 2:33 AM X-MAN <[email protected]> wrote:
>>
>> Hi,
>> I noticed an inconsistency in the documentation between UPDATE and DELETE
>> commands regarding the FOR PORTION OF clause description.
>>
>> In doc/src/sgml/ref/update.sgml (line 169), the description reads:
>> "must be in the form ( portion ) where portion is an expression..."
>>
>> In doc/src/sgml/ref/delete.sgml (line 166), it reads:
>> "must be in the form ( portion ), where portion is an expression..."
>
>Thanks for the patch! This looks good to me.
>
>Yours,
>
>--
>Paul ~{:-)
>[email protected]
Thanks a lot for the review!
--
X-MAN (Zizhuan Liu)
[email protected]
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2026-05-26 01:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-05-25 09:32 [PATCH] DOCS: Fix inconsistent text description punctuation in UPDATE FOR PORTION OF =?utf-8?B?WC1NQU4=?= <[email protected]>
2026-05-25 23:21 ` Paul A Jungwirth <[email protected]>
2026-05-26 01:59 ` =?utf-8?B?WC1NQU4=?= <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox