Message-ID: <08d943a83590308cbb9be594d80b4e19ca80e08e.camel@cybertec.at>
Subject: Re: analyze-in-stages post upgrade questions
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: "Zechman, Derek S" <Derek.S.Zechman@snapon.com>, Adrian Klaver
	 <adrian.klaver@aklaver.com>, "pgsql-general@lists.postgresql.org"
	 <pgsql-general@lists.postgresql.org>
Date: Wed, 09 Jul 2025 17:26:02 +0200
In-Reply-To: <PH0PR04MB8294E796D6297D4E3BE4EFB6C049A@PH0PR04MB8294.namprd04.prod.outlook.com>
References: 
	<CO1PR04MB8281387B9AD9DE30976966BBC045A@CO1PR04MB8281.namprd04.prod.outlook.com>
			 <6add2a9a-7cf2-4d1b-8f3e-2e26a7ebe883@aklaver.com>
		 <4d8122febd3007143504e4b6034b4253f7000761.camel@cybertec.at>
		 <PH0PR04MB82943D67CD179002714AA503C044A@PH0PR04MB8294.namprd04.prod.outlook.com>
	 <f2ebeef82fddaf8a8152383f8ff62e75f20aac3c.camel@cybertec.at>
	 <PH0PR04MB8294E796D6297D4E3BE4EFB6C049A@PH0PR04MB8294.namprd04.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.56.2 (3.56.2-1.fc42) 
MIME-Version: 1.0
Archived-At: <https://www.postgresql.org/message-id/08d943a83590308cbb9be594d80b4e19ca80e08e.camel%40cybertec.at>
Precedence: bulk

On Wed, 2025-07-09 at 11:30 +0000, Zechman, Derek S wrote:
> > > There are no entries in pg_stats for the parent table until after I m=
anually run an analyze on it =E2=80=93 Example below
> >
> > You are right.=C2=A0 I looked at the code, and "vacuumdb" does not proc=
ess
> > partitiond tables, even if --analyze-only is specified.=C2=A0 I find th=
at
> > surprising, aince the SQL command ANALYZE (without a table name) will
> > also collect statistics for partitioned tables.
> >
> > I think that it would be a good idea to change that behavior.
> > In particular, it makes a lot of sense to collect statistics for
> > partitioned tables after a "pg_upgrade".
> >
> > Attached is a patch to make "vacuumdb --analyze-only" consider
> > partitioned tables as well.
>=20
> Is there a plan to include this patch in future releases/patches of postg=
res?=20

I have added the patch to the current commitfest:
https://commitfest.postgresql.org/patch/5871/

So far, it has not got any peer review.  So yes, I'd like to include
the patch, but I cannot make it happen by myself.
Essentially, patches get applied if
a) they get peer review and
b) a committer applies them

If you want this to happen, the best thing you could do would be
to review the patch and see if it works for you, if it does what you
need and so on:
https://wiki.postgresql.org/wiki/Reviewing_a_Patch

Yours,
Laurenz Albe