From: Tom Lane <tgl@sss.pgh.pa.us>
To: depesz@depesz.com
cc: Laurenz Albe <laurenz.albe@cybertec.at>,
        pgsql-general <pgsql-general@lists.postgresql.org>
Subject: Re: Can we get rid of repeated queries from pg_dump?
In-reply-to: <20210828064650.GB11579@depesz.com>
References: <20210826084430.GA26282@depesz.com>
 <648517.1629986527@sss.pgh.pa.us> <20210826140827.GA15868@depesz.com>
 <649446.1629987629@sss.pgh.pa.us> <20210826160644.GA3120@depesz.com>
 <e6a7503afd115d111fbb96c5787906d73cfe2605.camel@cybertec.at>
 <896732.1630099403@sss.pgh.pa.us> <20210828064650.GB11579@depesz.com>
Comments: In-reply-to hubert depesz lubaczewski <depesz@depesz.com>
	message dated "Sat, 28 Aug 2021 08:46:50 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1004389.1630160930.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sat, 28 Aug 2021 10:28:50 -0400
Message-ID: <1004390.1630160930@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1004390.1630160930%40sss.pgh.pa.us>
Precedence: bulk

hubert depesz lubaczewski <depesz@depesz.com> writes:
> On Fri, Aug 27, 2021 at 05:23:23PM -0400, Tom Lane wrote:
>> Those queries are coming from getFormattedTypeName(), which is used
>> for function arguments and the like.  I'm not quite sure why Hubert
>> is seeing 5000 such calls in a database with only ~100 functions;
>> surely they don't all have an average of 50 arguments?

> 23 functions with 0 arguments, 52 with 1, and the max is 5 arguments - t=
wo
> functions have these.
> Not sure if it matters but there is a lot of enums. 83 of them. And they=
 have
> up to 250 elements (2 such types).

Hmm, no, I don't see any getFormattedTypeName calls in dumpEnumType.

There are two of 'em in dumpCast though.  Does this DB by chance
have a ton of user-defined casts?

			regards, tom lane