Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1rnli6-00F2T6-Nv
	for pgsql-hackers@arkaria.postgresql.org; Fri, 22 Mar 2024 20:41:55 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1rnli5-007Hn5-59
	for pgsql-hackers@arkaria.postgresql.org; Fri, 22 Mar 2024 20:41:53 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1rnli4-007Hmw-S1
	for pgsql-hackers@lists.postgresql.org; Fri, 22 Mar 2024 20:41:53 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1rnli2-005y1g-UN
	for pgsql-hackers@lists.postgresql.org; Fri, 22 Mar 2024 20:41:52 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 42MKfnYF1084643;
	Fri, 22 Mar 2024 16:41:49 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
cc: pgsql-hackers@lists.postgresql.org, alex work <alexwork033@gmail.com>,
        Robert Haas <robertmhaas@gmail.com>
Subject: Re: Slow GRANT ROLE on PostgreSQL 16 with thousands of ROLEs
In-reply-to: <20240322193506.GA2352051@nathanxps13>
References: <642442.1711053105@sss.pgh.pa.us>
 <20240321204012.GA1992418@nathanxps13> <20240322005139.GA2060816@nathanxps13>
 <806361.1711069194@sss.pgh.pa.us> <20240322144739.GA2321246@nathanxps13>
 <20240322145532.GA2346110@nathanxps13> <907785.1711121266@sss.pgh.pa.us>
 <20240322163952.GA2347986@nathanxps13> <939945.1711126395@sss.pgh.pa.us>
 <20240322165448.GA2350322@nathanxps13> <20240322193506.GA2352051@nathanxps13>
Comments: In-reply-to Nathan Bossart <nathandbossart@gmail.com>
	message dated "Fri, 22 Mar 2024 14:35:06 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1084641.1711140109.1@sss.pgh.pa.us>
Date: Fri, 22 Mar 2024 16:41:49 -0400
Message-ID: <1084642.1711140109@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/1084642.1711140109%40sss.pgh.pa.us>
Precedence: bulk

Nathan Bossart <nathandbossart@gmail.com> writes:
> On Fri, Mar 22, 2024 at 11:54:48AM -0500, Nathan Bossart wrote:
>> On Fri, Mar 22, 2024 at 12:53:15PM -0400, Tom Lane wrote:
>>> Would you like to review the catcache patch further, or do you
>>> think it's good to go?

>> I'll take another look this afternoon.

> LGTM

Thanks for looking, I'll push that shortly.

			regards, tom lane