From: Tom Lane <tgl@sss.pgh.pa.us>
To: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@alvh.no-ip.org>
cc: "David G. Johnston" <david.g.johnston@gmail.com>,
        Sebastien Flaesch <sebastien.flaesch@4js.com>,
        Adrian Klaver <adrian.klaver@aklaver.com>,
        M Tarkeshwar Rao <m.tarkeshwar.rao@ericsson.com>,
        "pgsql-general@postgresql.org" <pgsql-general@postgresql.org>
Subject: Re: After upgrading libpq, the same function(PQftype) call returns a different OID
In-reply-to: <202503201748.wxkazqupyvuk@alvherre.pgsql>
References: <202503201748.wxkazqupyvuk@alvherre.pgsql>
Comments: In-reply-to =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@alvh.no-ip.org>
	message dated "Thu, 20 Mar 2025 18:48:27 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1092932.1742496844.1@sss.pgh.pa.us>
Date: Thu, 20 Mar 2025 14:54:04 -0400
Message-ID: <1092933.1742496844@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/1092933.1742496844%40sss.pgh.pa.us>
Precedence: bulk

=?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@alvh.no-ip.org> writes:
> That said, we could add a comment that makes this more obvious:
> ...
> This looks a tad redundant in pg_type.h itself, but makes the generated
> pg_type_d.h file more obvious:

I think it's a mistake to suppose that pg_type_d.h is the only
place where there's a risk of confusion.  We should be thinking
about this more generally: genbki.pl is taking zero thought to
make what it emits readable.  I think it would help to
label the sections it emits, perhaps along the lines of

/* Auto-generated OID macros */

for this part, and I'm not sure what other parts would be useful
to label.

As for CASHOID and LSNOID, surely those have been deprecated long
enough that we could just remove them?

			regards, tom lane