Message-ID: <10ff0fbe7f4d711300951431ad28254aa5bf2dc4.camel@cybertec.at>
Subject: Re: Upsert error "column reference is ambiguous"
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Tim Starling <tstarling@wikimedia.org>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-general@lists.postgresql.org
Date: Tue, 29 Apr 2025 08:36:14 +0200
In-Reply-To: <5fe1d1c9-662e-405e-aaed-21d15bdbea06@wikimedia.org>
References: <a31a76b6-b176-47fe-8778-9dfece231341@wikimedia.org>
	 <697017.1745837694@sss.pgh.pa.us>
	 <80f95342-cc09-4236-a2d7-68538fbfc41b@wikimedia.org>
	 <774865.1745848449@sss.pgh.pa.us>
	 <5fe1d1c9-662e-405e-aaed-21d15bdbea06@wikimedia.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.54.3 (3.54.3-1.fc41) 
MIME-Version: 1.0
Archived-At: <https://www.postgresql.org/message-id/10ff0fbe7f4d711300951431ad28254aa5bf2dc4.camel%40cybertec.at>
Precedence: bulk

On Tue, 2025-04-29 at 08:36 +1000, Tim Starling wrote:
> My code would be like
>=20
> function upsert( $table, $names, $values, $key, $set ) {
> =C2=A0=C2=A0=C2=A0=C2=A0 if ( $this->type =3D=3D=3D 'mysql' ) {
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 $conflict =3D 'ON DUPLIC=
ATE KEY UPDATE';
> =C2=A0=C2=A0=C2=A0=C2=A0 } else {
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 $conflict =3D "ON CONFLI=
CT ($key) DO UPDATE SET";
> =C2=A0=C2=A0=C2=A0=C2=A0 }
> =C2=A0=C2=A0=C2=A0=C2=A0 return $this->query( "INSERT INTO $table ($names=
) " .
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "VALUES ($values) $confl=
ict $set" );
> }
>=20
> The parameters are a little bit more structured than that, but that=20
> gives you the idea.

Another litle "if" to cater for PostgreSQL's "EXCLUDED." would be
such a big problem?

Yours,
Laurenz Albe