From: Tom Lane <tgl@sss.pgh.pa.us>
To: Sami Imseih <samimseih@gmail.com>
cc: Michael Paquier <michael@paquier.xyz>, Christoph Berg <myon@debian.org>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
        ma lz <ma100@hotmail.com>
Subject: Re: query_id: jumble names of temp tables for better pg_stat_statement UX
In-reply-to: <CAA5RZ0t4XQ_SANiJ5VfuoKnAuxMaY2ggQWoGKkHo+U2H+Sh-Sw@mail.gmail.com>
References: <Z9qybg3FxTUefRT7@msg.df7cb.de> <Z9y43-dRvb4EtxQ0@paquier.xyz> <Z92TLJ5MmSU_lyxa@msg.df7cb.de> <Z93sH12uzCQHfOo-@paquier.xyz> <Z96GJEmTnvHKz_Kn@msg.df7cb.de> <Z96Rz-4IEyRCS4ny@paquier.xyz> <1831838.1742656359@sss.pgh.pa.us> <80506.1742660683@sss.pgh.pa.us> <Z99aIy9T0f-lulK5@paquier.xyz> <461405.1742691859@sss.pgh.pa.us> <Z9-sUvq8pE5uinEu@paquier.xyz> <CAA5RZ0t4XQ_SANiJ5VfuoKnAuxMaY2ggQWoGKkHo+U2H+Sh-Sw@mail.gmail.com>
Comments: In-reply-to Sami Imseih <samimseih@gmail.com>
	message dated "Mon, 24 Mar 2025 20:51:14 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1189111.1742869660.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Mon, 24 Mar 2025 22:27:40 -0400
Message-ID: <1189112.1742869660@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/1189112.1742869660%40sss.pgh.pa.us>
Precedence: bulk

Sami Imseih <samimseih@gmail.com> writes:
> For example, I have seen users add comments to SQLs to differentiate
> similar SQLs coming from different tenants. This patch makes this no lon=
ger a
> somewhat decent workaround  to overcome the fact that pg_stat_statements
> does not track schemas or search path.

Well, the workaround is different, but that doesn't mean there is no
workaround.  You just need to alter a table alias in the query:

select * from foo s1;
select * from foo s2;

As against this, there is probably also a set of people who would
*like* identical queries on identically-rowtyped tables in different
schemas to be merged.  Right now they have no way to make that happen.

So yeah, it's a nontrivial behavioral change.  But I think on the
whole it's likely to be more useful.  We could always revert the
change during beta if we get too much pushback.

			regards, tom lane