From: Tom Lane <tgl@sss.pgh.pa.us>
To: "David G. Johnston" <david.g.johnston@gmail.com>
cc: PopeRigby <poperigby@mailbox.org>,
        Adrian Klaver <adrian.klaver@aklaver.com>,
        "pgsql-general@postgresql.org" <pgsql-general@postgresql.org>
Subject: Re: Errors when restoring backup created by pg_dumpall
In-reply-to: <CAKFQuwbe4TSU_LxsrGxgcv4DfQq2x-UNoyKx-ABy36PhvbGCdg@mail.gmail.com>
References: <6a6439f1-8039-44e2-8fb9-59028f7f2014@mailbox.org> <cba48d2c-0987-4233-a86f-2e693677efd3@aklaver.com> <9c5ba566-27b8-4e8c-bf7d-2dc561509991@mailbox.org> <CAKFQuwaB5GuUNuyiUbS0ah-LYXepHLPnOHrP7g8RMz8ywOm3zQ@mail.gmail.com> <ff94f628-27af-4c3a-9590-cba38bb5d2d1@mailbox.org> <CAKFQuwYQUequkYVS8SLgC1L0TOdWNK=xVyxnPD9RPPwfvYRFSQ@mail.gmail.com> <41791b6d-aaf5-4fed-9cc3-e89bc49e8637@mailbox.org> <CAKFQuwbe4TSU_LxsrGxgcv4DfQq2x-UNoyKx-ABy36PhvbGCdg@mail.gmail.com>
Comments: In-reply-to "David G. Johnston" <david.g.johnston@gmail.com>
	message dated "Sat, 30 Nov 2024 20:45:55 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1257067.1733025493.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sat, 30 Nov 2024 22:58:13 -0500
Message-ID: <1257068.1733025493@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/1257068.1733025493%40sss.pgh.pa.us>
Precedence: bulk

"David G. Johnston" <david.g.johnston@gmail.com> writes:
> Ok, so the error is not emanating from your code but rather the body of =
the
> ll_to_earth function defined in the earthdistance extension.

Yeah.  That is

CREATE FUNCTION ll_to_earth(float8, float8)
RETURNS earth
LANGUAGE SQL
IMMUTABLE STRICT
PARALLEL SAFE
AS 'SELECT cube(cube(cube(earth()*cos(radians($1))*cos(radians($2))),earth=
()*cos(radians($1))*sin(radians($2))),earth()*sin(radians($1)))::earth';

which is problematic: the function calls are not schema-qualified and
there's not a really easy way to fix that.  There's work afoot to fix
that [1], but it's not committed yet let alone in any shipping
version.  Nonetheless, your best bet for fixing this might be
to install the earthdistance 1.2 files from the latest patchset in
that thread.

			regards, tom lane

[1] https://www.postgresql.org/message-id/flat/3395418.1618352794@sss.pgh.=
pa.us