From: Tom Lane <tgl@sss.pgh.pa.us>
To: "David G. Johnston" <david.g.johnston@gmail.com>
cc: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@alvh.no-ip.org>,
        Sebastien Flaesch <sebastien.flaesch@4js.com>,
        Adrian Klaver <adrian.klaver@aklaver.com>,
        M Tarkeshwar Rao <m.tarkeshwar.rao@ericsson.com>,
        "pgsql-general@postgresql.org" <pgsql-general@postgresql.org>
Subject: Re: After upgrading libpq, the same function(PQftype) call returns a different OID
In-reply-to: <CAKFQuwZOCZB19s_mup7CDqLoTyH3Q5dAf7Qf8uR-pwoN47yKMA@mail.gmail.com>
References: <202503201748.wxkazqupyvuk@alvherre.pgsql> <1092933.1742496844@sss.pgh.pa.us> <CAKFQuwZYCktj5Ect4f5Mx1OejCRbQ+MoKWQN+F=2Oid5M=3E7Q@mail.gmail.com> <1134562.1742507765@sss.pgh.pa.us> <CAKFQuwZOCZB19s_mup7CDqLoTyH3Q5dAf7Qf8uR-pwoN47yKMA@mail.gmail.com>
Comments: In-reply-to "David G. Johnston" <david.g.johnston@gmail.com>
	message dated "Fri, 21 Mar 2025 08:14:14 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <1586472.1742583372.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Fri, 21 Mar 2025 14:56:12 -0400
Message-ID: <1586473.1742583372@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/1586473.1742583372%40sss.pgh.pa.us>
Precedence: bulk

"David G. Johnston" <david.g.johnston@gmail.com> writes:
> On Thu, Mar 20, 2025 at 2:56 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> That's documented elsewhere, I believe.  For the foo_d.h files,
>> I think it'd be sufficient to do something like 0001 attached.

> WFM.  Thanks.

Thanks for looking at it.

>> Also, while checking out the results, I noticed that pg_class.h
>> has an "extern" in the wrong place: it's exposed to client code
>> which can have no use for it.  That extern doesn't mention any
>> backend-only typedefs, so it's fairly harmless, but it's still
>> a clear example of somebody not reading the memo.  Hence 0002.

> Maybe tack this onto genbki.h?

> diff --git a/src/include/catalog/genbki.h b/src/include/catalog/genbki.h
> index 26e205529d..4a1567a46b 100644
> --- a/src/include/catalog/genbki.h
> +++ b/src/include/catalog/genbki.h
> @@ -146,4 +146,6 @@
>   */
>  #undef EXPOSE_TO_CLIENT_CODE

> +/* Additional backend-only code is placed after the client-code section. */
> +
>  #endif                                                 /* GENBKI_H */

Doubt that would help ...

			regards, tom lane