Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oXjn7-0008NI-Jp for pgsql-general@arkaria.postgresql.org; Mon, 12 Sep 2022 13:48:01 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oXjn4-0002fr-R7 for pgsql-general@arkaria.postgresql.org; Mon, 12 Sep 2022 13:47:58 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oXjn4-0002fc-G4 for pgsql-general@lists.postgresql.org; Mon, 12 Sep 2022 13:47:58 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oXjn2-0000uf-3O for pgsql-general@lists.postgresql.org; Mon, 12 Sep 2022 13:47:57 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 28CDlpvx1606994; Mon, 12 Sep 2022 09:47:51 -0400 From: Tom Lane To: Daniel Gustafsson cc: Peter Eisentraut , Sebastien Flaesch , "pgsql-general@lists.postgresql.org" Subject: Re: lippq client library and openssl initialization: PQinitOpenSSL() In-reply-to: References: <816006.1662908880@sss.pgh.pa.us> <9A09E47E-68EB-45DF-A934-FB76F2086D20@yesql.se> <1206133.1662932104@sss.pgh.pa.us> <6b1946ab-b6ff-8f0c-22d9-2456b04dd1b3@enterprisedb.com> Comments: In-reply-to Daniel Gustafsson message dated "Mon, 12 Sep 2022 13:55:29 +0200" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1606992.1662990471.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Mon, 12 Sep 2022 09:47:51 -0400 Message-ID: <1606993.1662990471@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Daniel Gustafsson writes: > On 12 Sep 2022, at 13:21, Peter Eisentraut wrote: >> AFAICT, RHEL 7 ships with an older version. I think that's still pretty= widespread. > Fair enough. That doesn't however IMO prevent us from adding a note tha= t 1.1.0 > and onwards are different. The attached keeps the strong wording of the= main > para, but adds a note after the related functions. Personally I'd put this up front, more like have been initialized by your application, so that libpq will not also initialize those librari= es. + However, this is unnecessary when using OpenSSL 1.1.0 or later, + as duplicate initializations are no longer problematic. If you do use wording that specifically mentions PQinitOpenSSL, it should also mention PQinitSSL, just for clarity. regards, tom lane