From: Tom Lane <tgl@sss.pgh.pa.us>
To: Dean Rasheed <dean.a.rasheed@gmail.com>
cc: jian he <jian.universality@gmail.com>,
        pgsql-general list <pgsql-general@lists.postgresql.org>
Subject: Re: security invoker review need full select (all columns) to do DML?
In-reply-to: <CAEZATCVm+2Vr4ydMBZNGJuFNbH7YZOOXSEJ8JyjWeQ4J5xZ5zQ@mail.gmail.com>
References: <CACJufxG31b+LwmxHz6xw9Qr+qc3VgQaRdpiaGUoZFrf=NBu48g@mail.gmail.com> <CAEZATCVm+2Vr4ydMBZNGJuFNbH7YZOOXSEJ8JyjWeQ4J5xZ5zQ@mail.gmail.com>
Comments: In-reply-to Dean Rasheed <dean.a.rasheed@gmail.com>
	message dated "Wed, 21 Aug 2024 13:26:49 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1777284.1724251184.1@sss.pgh.pa.us>
Date: Wed, 21 Aug 2024 10:39:44 -0400
Message-ID: <1777285.1724251184@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/1777285.1724251184%40sss.pgh.pa.us>
Precedence: bulk

Dean Rasheed <dean.a.rasheed@gmail.com> writes:
> The user must have select permissions on all columns selected by the
> subquery/view, because we don't go through the outer query to check
> which columns are actually referred to. Now maybe we could, but I
> suspect that would be quite a lot of effort because you'd need to be
> sure that the column wasn't referred to anywhere in either the outer
> query or the subquery itself (e.g., in WHERE clauses, etc.).

I'd argue that we should check that permission regardless, and are
probably required to by the SQL spec.  You don't normally get to
escape permission checks when bits of the query are optimized away.
(This is why permission checks are done on the range table not the
plan tree.)

			regards, tom lane