Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iS0K5-0002Fl-46 for pgsql-hackers@arkaria.postgresql.org; Tue, 05 Nov 2019 15:00:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iS0K3-0006uv-SX for pgsql-hackers@arkaria.postgresql.org; Tue, 05 Nov 2019 15:00:43 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iS0K3-0006uo-Jq for pgsql-hackers@lists.postgresql.org; Tue, 05 Nov 2019 15:00:43 +0000 Received: from tamriel.snowman.net ([96.255.250.162]) by magus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iS0Jx-000166-5u for pgsql-hackers@lists.postgresql.org; Tue, 05 Nov 2019 15:00:42 +0000 Received: by tamriel.snowman.net (Postfix, from userid 1000) id 52C065F7A7; Tue, 5 Nov 2019 10:00:35 -0500 (EST) Date: Tue, 5 Nov 2019 10:00:35 -0500 From: Stephen Frost To: Tom Lane Cc: Peter Eisentraut , Alvaro Herrera , "imai.yoshikazu@fujitsu.com" , Euler Taveira , Andrew Gierth , Justin Pryzby , PostgreSQL Hackers Subject: Re: v12 and pg_restore -f- Message-ID: <20191105150035.GN6962@tamriel.snowman.net> References: <20191104145336.GA23924@alvherre.pgsql> <5e124b1d-bd8f-0659-1088-4952464223bc@2ndquadrant.com> <20191105141132.GK6962@tamriel.snowman.net> <7897.1572964109@sss.pgh.pa.us> <20191105143812.GM6962@tamriel.snowman.net> <8586.1572965160@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="h0e9bZ/O9hzQ48Jg" Content-Disposition: inline In-Reply-To: <8586.1572965160@sss.pgh.pa.us> User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --h0e9bZ/O9hzQ48Jg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Greetings, * Tom Lane (tgl@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > * Tom Lane (tgl@sss.pgh.pa.us) wrote: > >> In this case, not in the least: we would simply be imposing the sort > >> of *orderly* feature introduction that I thought was the plan from > >> the very beginning [1]. That is, first make "-f -" available, and > >> make it required only in some later version. If we'd back-patched > >> the optional feature back in April, it might've been okay to require > >> it in v12, but we failed to provide any transition period. >=20 > > ... just like we didn't provide any transistion period for the > > recovery.conf changes. >=20 > Sure, because there wasn't any practical way to provide a transition > period. I think that case is entirely not comparable to this one, > either as to whether a transition period is possible, or as to whether > the benefits of the change merit forced breakage. We didn't put any effort into trying to provide a transition period, and for good reason- everyone gets 5 years of transition time. I'd be just as happy to not even commit the change to make -f- go to stdout in the back-branches, if I didn't feel that the behavior of it going to a file called ./- was really just an outright bug in the first place. Thanks, Stephen --h0e9bZ/O9hzQ48Jg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJdwY6SAAoJEO1sijiDR2RV4GgQAKp6DAThZ9Do9Qp+Hn0rrSgI no+3bgACuGLEUjo3wHhPWXyLnRknS7AU/G1ZkYRLgU+gpA6Ml5p7nZ2Tgt1q3RV1 EMBdHnPN0Htwi+8ifeCVLpVyIRXlf126n5kQ12wYmFt60yo+Bz2JgNPJFhXfqJ1e DokFWeyzmzozvou1T85WOYENsPGTRslixQ7WObtxm64oK3PTq57js4hGa0He52on ki/7jBzQ/SHKlcAzy7e4k31NFKSyjbE/z5rdgkofmZlvLYH4KC2Ks2wiYBMe/tVI Nq7LJfCiDSkH4/KaowHHA2OucK+uk64Zl59F1WcCKh9ysFp7iyTJ7phLDY+fp3qy 2su+Uawk6M17vizd89wLe27lIh95EuooKE96QtU4ALjo4LDQBvLq4KL9Go8QA8qf 6/OjwseKEaclUT6xJ+5iUpWOq7iC2GG4WD1p2AUjxnP5fD8EWde/q1UZ2HO38oWQ 9fPSu1UvdTkvALNk/eA3RZNwkIMwYXz0Yk22EAqPsT3qn4y+1T3SdQRu8iKLRiOh OAPaEcNqdPqKghn29NAudIcWqBlU6Tdzapjim2wUjfSYlEVdTcn+rULlUyEIBB3Y dZKps+4egG+vWGbXaRZdcTduwO1MCu4tvStAlkPs+TbzVBJoJ3UbY5Iabw/e64eS gpb3j7nsISbzKDrTw7t6 =n4Sz -----END PGP SIGNATURE----- --h0e9bZ/O9hzQ48Jg--