Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ooiAw-00064n-Be for pgsql-hackers@arkaria.postgresql.org; Sat, 29 Oct 2022 09:30:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ooiAu-0006Hp-VE for pgsql-hackers@arkaria.postgresql.org; Sat, 29 Oct 2022 09:30:44 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ooiAu-0006Hg-LW for pgsql-hackers@lists.postgresql.org; Sat, 29 Oct 2022 09:30:44 +0000 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ooiAn-0006yT-6J for pgsql-hackers@lists.postgresql.org; Sat, 29 Oct 2022 09:30:44 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 4F2B5320069B; Sat, 29 Oct 2022 05:30:32 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sat, 29 Oct 2022 05:30:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:reply-to:sender :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1667035831; x=1667122231; bh=d qkpnGbArY+iXC51RBblAJoRmekbbdWOzcay+CqYvGM=; b=U1nkmO5UyuDI/OutB 4xKZ3R7T0l4Ls/Gu6my2zA3k4kTjirNgksYd+/ealkZBNmFDs9ZrLyXiDUsT0gYZ 0LD3/QIzqosgizvNVx4oVUeslDdqnORrJrkeRFUmzUmHLavFO5lMaeWTc8slB8Gd +qxjIjD/M6vfdMhlu0lkmxJ0CscKQ+OSS6EdksrLRV7kbGCEVjiYVINtq1MZU6Wi b3j5jn4PD/zwptA3zF7/uN8axOhVlNBfTFJYKUKaBAMvtg8Scsl0GJjkos5+viB6 cRnWPLyeONUaSD8CgkrSGjq6Pw2DVYUUJIuxeHCEr+xTimil7fP5mj3Dqgyug1Gy 0f+1Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrtdekgdduiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfggtggugfgjsehtkeertddttdejnecuhfhrohhmpeetlhhvrghr ohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhgqe enucggtffrrghtthgvrhhnpedvkedtffduffdtffffheffhfejjefhgfeiueeukeejkeff gfdufffhudffffeuveenucffohhmrghinhepvghnthgvrhhprhhishgvuggsrdgtohhmne cuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghlvhhh vghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 29 Oct 2022 05:30:31 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 546E35D; Sat, 29 Oct 2022 11:30:42 +0200 (CEST) Date: Sat, 29 Oct 2022 11:30:42 +0200 From: Alvaro Herrera To: Peter Smith Cc: Zheng Li , Ajin Cherian , vignesh C , Dilip Kumar , "houzj.fnst@fujitsu.com" , Amit Kapila , Masahiko Sawada , Japin Li , rajesh singarapu , PostgreSQL Hackers Subject: Re: Support logical replication of DDLs Message-ID: <20221029093042.jj22fe3i5wqqtm4r@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022-Oct-28, Peter Smith wrote: > Hi, authors on this thread. > > The patch v32-0001 is very large, so it will take some time to review > the code in detail. Yes, and I think there are a few things that should be split out from it. Namely, all the stuff that generates the JSON blob should appear in a second patch after supporting changes to other places such as ruleutils and suchlike. -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/ "Estoy de acuerdo contigo en que la verdad absoluta no existe... El problema es que la mentira sí existe y tu estás mintiendo" (G. Lama)