Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rnHXh-00CUYw-RH for pgsql-general@arkaria.postgresql.org; Thu, 21 Mar 2024 12:29:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rnHXg-00D3if-A7 for pgsql-general@arkaria.postgresql.org; Thu, 21 Mar 2024 12:29:08 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rnHXe-00D3iX-Jj for pgsql-general@lists.postgresql.org; Thu, 21 Mar 2024 12:29:08 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rnHXa-005iy8-T2 for pgsql-general@postgresql.org; Thu, 21 Mar 2024 12:29:06 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 5863C5C0045; Thu, 21 Mar 2024 08:28:59 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 21 Mar 2024 08:28:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1711024139; x= 1711110539; bh=QUtB0UgRpwFmgNciBZV06ZEAi5JobEHR8VrVi2eVBrg=; b=U q9qVCZVBlfhB2ImBqqonxCPO2jVObcc6vg/Kf4wNo5+PYHgIEXoQ0Zo5ts1mmaMY vXF2Dxm9ZmW4RToDq1gEXO1mGbLheJNWMzsNGJAPHa2IFix59PXYfOi21o1CdJeA GbtMY9+6H66vkY09S+4AHCXAsxRXD5hNN8OugxHtgkFJ0IV0Xc4RxL49FPtmOtYM jppdGIS61zLmzygv7FBqwJjSD3pQTD2L5j+WgPkBlgEJWRpyFrbWFmGUVfZG/Efa v20OyBVKtJescx+totzgZ/SNLWK4uTNocgpb/ali7x+JSaJ4dJk0Gd2BP50tLLbi R8maq0+2a97nm85kIO76w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrleeigdegtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfggtggugfgjsehmkeerredttdejnecuhfhrohhmpeetlhhvrghr ohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhgqe enucggtffrrghtthgvrhhnpeehfeekteegueekveejhfehteetgfevfedvgeekvdevuddv vdetteelgfeffeeifeenucffohhmrghinhepphhoshhtghhrvghsqhhlrdhorhhgpdgvnh htvghrphhrihhsvggusgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgr mhepmhgrihhlfhhrohhmpegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhg X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 21 Mar 2024 08:28:57 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alvh.no-ip.org; s=schmee; t=1711024136; bh=e7ZfuKnSqz2Tlgr4BpoLG2SiHA6u+oivgELp9eB2wGQ=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=WlGiUOOphPIbzysXbR0v3k/0TRDmKPgDwwyDh//3lr6FDOmoD637JbrsylnxQNbPN Yhj5RPk72Aob4OImzf5/F0IVYEhDl9yZuciHjawSO0Xfz2R7HyYwxk2SbpaJicHXv+ 3bk9nXovNW0loQ9BK1nOP7T1msLBJuAlQEOJYyqUTEIUn4rfbEvtpk0VW9QxnSXON7 CZcwb1vD8SsB0gqoDTM/MKzBjy1RFM+v8k0Ye5hwupphyLflmdUSiL6C7vQVt6kD6L /e2oW2mYIWIP84KMNcsaUcmJK8S4bpzxJK702m6Eiq0RYrutDXx0OwxAvqpN+3SYzq JH0Q1CTGqEVPg== Received: by schmee.alvh.no-ip.org (Postfix, from userid 1000) id 9A5B23C9; Thu, 21 Mar 2024 13:28:56 +0100 (CET) Date: Thu, 21 Mar 2024 13:28:56 +0100 From: Alvaro Herrera To: Daniel Gustafsson Cc: Bartosz =?utf-8?B?Q2hyb8WC?= , "pgsql-general@postgresql.org" Subject: Re: pg_dumpall with flag --no-role-passwords omits roles comments as well Message-ID: <202403211228.4szqmhopsskk@alvherre.pgsql> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="5srwxcr3o5ojzrxr" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <86FC9F16-E6AA-4C04-B0FB-024662CA8D2A@yesql.se> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --5srwxcr3o5ojzrxr Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On 2024-Mar-21, Daniel Gustafsson wrote: > Comments on roles are stored against the pg_authid catalog relation which is > the catalog used for dumping roles, but when using --no-role-passwords we > instead switch to using the pg_roles catalog relation. Since comments are > dumped for the relations which are dumped, this means that the comments on > roles are omitted when --no-role-passwords is used. > > It's not clear whether that was intentional or not, I'm failing to find the > thread where it was discussed on a quick mailing list search. Here it is: https://www.postgresql.org/message-id/flat/CAEP4nAz9V4H41_4ESJd1Gf0v%3DdevkqO1%3Dpo91jUw-GJSx8Hxqg%40mail.gmail.com I very much doubt that they realized that comments were going to be omitted. But clearly it's just a mistake, and easily fixed. -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/ "After a quick R of TFM, all I can say is HOLY CR** THAT IS COOL! PostgreSQL was amazing when I first started using it at 7.2, and I'm continually astounded by learning new features and techniques made available by the continuing work of the development team." Berend Tober, http://archives.postgresql.org/pgsql-hackers/2007-08/msg01009.php --5srwxcr3o5ojzrxr Content-Type: text/x-diff; charset=utf-8 Content-Disposition: attachment; filename="v1-0001-fix-dump-of-role-comments-with-no-role-passwords.patch"