Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rnISK-00CZO3-Vh for pgsql-general@arkaria.postgresql.org; Thu, 21 Mar 2024 13:27:41 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rnISJ-00DTFg-JE for pgsql-general@arkaria.postgresql.org; Thu, 21 Mar 2024 13:27:40 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rnISI-00DTFO-Np for pgsql-general@lists.postgresql.org; Thu, 21 Mar 2024 13:27:39 +0000 Received: from fout8-smtp.messagingengine.com ([103.168.172.151]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rnISF-005jRN-Vq for pgsql-general@postgresql.org; Thu, 21 Mar 2024 13:27:38 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfout.nyi.internal (Postfix) with ESMTP id 0102F13800DD; Thu, 21 Mar 2024 09:27:34 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 21 Mar 2024 09:27:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1711027653; x= 1711114053; bh=olvwz7jg3qwaC9eG1r9aNgU9JV0S4N18kRfln8pen7g=; b=n cVXXVtnhD5PnH7FJO/kLIZ4s8oQOQ+YJXQ/sspMNYn87kQRY05s68j6FYJ5cqfpH iXGmWxCeqjuHbaXvWF2n2gLqmXXqecfnf9Ca6sJ6znwXedfcW5qllSpxh2gc3iMh dk8ugY4w4HyZuSUodTwhwwiTh5i8d5WKmO4bDB+hdEM6h/wyTSjMx7V1vlHOoj7M mL5kqEquhq04NGGcCT0L6RHH4wag1YrqDFN6wIPIBLg87YRhISqWYw5Xe/eGaUlh 1uXZ3aQxwmv39wrTWOxAdMC+hmwuuou/MKtPMICAUeoz0kBUnTQUL5Z9LYcG7fsW vGoQ8NFRwOhhCpB/YnkZQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrleeigdehvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfggtggugfgjsehtkeertddttdejnecuhfhrohhmpeetlhhvrghr ohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhgqe enucggtffrrghtthgvrhhnpeelvdekvdeuleetfeffveejgfefueelheejtdeiveejleff geefleegvdetkedvteenucffohhmrghinhepvghnthgvrhhprhhishgvuggsrdgtohhmpd hpohhsthhgrhdrvghsnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi lhhfrhhomheprghlvhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 21 Mar 2024 09:27:33 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alvh.no-ip.org; s=schmee; t=1711027650; bh=2JjtA68TohJ//zOVALW8JgVXXpbnLhPuJsTVH3O0FtE=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=PAVF7GN9VmEZImwV6gQApPm1ppgQv2BsuLgSRFBxUyYD707yitsil4paktiCnNACP d+9SIIZTOy5eDi5Sk7Wh5rY2y9B+uQIGKhPmnel5YdVMOGJbUzjVRD1TrEbg9VwJwC uVWkwCsG0Ii/shuw0Xk6+GaaNrOexdQYRNXqb3fxTBqVYkAkNrxvyYNFkEfHTukbHQ kwtogk0rTpEAkz8jOBatR6EYwtkwm5QMggdaj+dcZE+o/7LpjZYjl90cDNpNWABbBK +41muNAAirGhSQ5a443G/SnMN/VQggV3O9yA/P5O/swURdAepmFnm0Wd/uHwg6/tLK 2N5zusj6PHv5g== Received: by schmee.alvh.no-ip.org (Postfix, from userid 1000) id 1AB563C9; Thu, 21 Mar 2024 14:27:30 +0100 (CET) Date: Thu, 21 Mar 2024 14:27:30 +0100 From: Alvaro Herrera To: Daniel Gustafsson Cc: Bartosz =?utf-8?B?Q2hyb8WC?= , "pgsql-general@postgresql.org" Subject: Re: pg_dumpall with flag --no-role-passwords omits roles comments as well Message-ID: <202403211327.3mwhawgoeqp3@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <33D59EC6-C78F-410D-964B-80449B76EA96@yesql.se> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2024-Mar-21, Daniel Gustafsson wrote: > On 21 Mar 2024, at 13:28, Alvaro Herrera wrote: > > > I very much doubt that they realized that comments were going to be > > omitted. But clearly it's just a mistake, and easily fixed. > > It sure looks like a search/replace kind of bug. I had just typed up the exact > same patch with the addition of a comment on why pg_authid is used and was > about to hit send when your email came =) Are you committing it or do you want > me to take care of it? Hah :-) Please do. -- Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/ "Here's a general engineering tip: if the non-fun part is too complex for you to figure out, that might indicate the fun part is too ambitious." (John Naylor) https://postgr.es/m/CAFBsxsG4OWHBbSDM%3DsSeXrQGOtkPiOEOuME4yD7Ce41NtaAD9g%40mail.gmail.com