Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rnkhX-00Evah-5i for pgsql-hackers@arkaria.postgresql.org; Fri, 22 Mar 2024 19:37:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rnkhV-00706Q-Pu for pgsql-hackers@arkaria.postgresql.org; Fri, 22 Mar 2024 19:37:14 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rnkfZ-006wOM-8z for pgsql-hackers@lists.postgresql.org; Fri, 22 Mar 2024 19:35:13 +0000 Received: from mail-io1-xd30.google.com ([2607:f8b0:4864:20::d30]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rnkfW-005xcH-66 for pgsql-hackers@lists.postgresql.org; Fri, 22 Mar 2024 19:35:12 +0000 Received: by mail-io1-xd30.google.com with SMTP id ca18e2360f4ac-7cbf307213fso117119539f.0 for ; Fri, 22 Mar 2024 12:35:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711136108; x=1711740908; darn=lists.postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hmNK+5m7BL5ehm9mqe6flaGlTqKFgE3Hweh0NcpFcgg=; b=WDKawbhr28+Rl0XlS4MxwpNjjRX97hKN585AXl8FzvosqMwaXBuTpQFdqaFUBnonfX nW1Kplg0ehK+ViSvGbepDBpzbDV2OfsleBqNZAmScqh/+UU3ehJxBIzMFKW4no492jhJ GoUUsRrPhQ7FfyrNVf2b1lHCnMgetsPi583ZPOQc0dBCbWuDTAAH9Qp10OOIWMmcHM8f +n/Qt6avBqcnPEQs7qPA1mx+do3kvDhiVZTQ97G2C0vJ8e71m43EjqSd5oSWUHG9oksM 4XdzY3Qv9+luiuMJ7tt6Ikbe/r+A5GYNgdZwZjdenD0IV2VZmAsf71lDZ45hr/uDqg8L LCJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711136108; x=1711740908; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hmNK+5m7BL5ehm9mqe6flaGlTqKFgE3Hweh0NcpFcgg=; b=qWXJlcxs6pFHOXRnqrbE8lZ833IS4+QYANAl4plS18EwQr/W6kUsEGSh4agd2wHfEn PYj0EqgrqLfiNrW38tl2DE4aMInnGsuVa6qc9SB3QusuNkF4Fh67NlwDW48dMzyWqaVz QD/CQqiGG8OHoLCwlFmH+5zggX2fy+i9Cw9K/TTJMv48w5cmwE85QEKv4RyZZsL3ziQF 1hZNX5ygCmioj/u+o68czA3ZHx3//3FqG7fcs5qg1r9zBsn+4+18/urTKYzcHdV0Bko7 fof4vRXhHC4v3Md9xcPzVQGdC3IS0eVYK0+8FjW9C/TebUeNwfUN0u/uDsYih3FF3SQg tixg== X-Gm-Message-State: AOJu0YwQoadr5PFbj8TX8W1SsV7SvgdcOSeJHr6+2I7F8+yDrocvvypc hxwFlZMpzQ03JyeCacO+Nc/zNhjkAVmi0DRBKEsg4Ph2N33g5xU9 X-Google-Smtp-Source: AGHT+IF16CaXR+oMwlvJOnbFtQeQ+GNu4HtRsBKrLKK71/tNHMGy1aAT/fFQGqlHmX2V1BOgI0rJFw== X-Received: by 2002:a5e:8f0d:0:b0:7cf:2245:80af with SMTP id c13-20020a5e8f0d000000b007cf224580afmr467832iok.16.1711136108215; Fri, 22 Mar 2024 12:35:08 -0700 (PDT) Received: from nathanxps13 (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id c10-20020a02a60a000000b0047beee2f3bcsm677186jam.143.2024.03.22.12.35.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Mar 2024 12:35:07 -0700 (PDT) Date: Fri, 22 Mar 2024 14:35:06 -0500 From: Nathan Bossart To: Tom Lane Cc: pgsql-hackers@lists.postgresql.org, alex work , Robert Haas Subject: Re: Slow GRANT ROLE on PostgreSQL 16 with thousands of ROLEs Message-ID: <20240322193506.GA2352051@nathanxps13> References: <642442.1711053105@sss.pgh.pa.us> <20240321204012.GA1992418@nathanxps13> <20240322005139.GA2060816@nathanxps13> <806361.1711069194@sss.pgh.pa.us> <20240322144739.GA2321246@nathanxps13> <20240322145532.GA2346110@nathanxps13> <907785.1711121266@sss.pgh.pa.us> <20240322163952.GA2347986@nathanxps13> <939945.1711126395@sss.pgh.pa.us> <20240322165448.GA2350322@nathanxps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240322165448.GA2350322@nathanxps13> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Fri, Mar 22, 2024 at 11:54:48AM -0500, Nathan Bossart wrote: > On Fri, Mar 22, 2024 at 12:53:15PM -0400, Tom Lane wrote: >> Would you like to review the catcache patch further, or do you >> think it's good to go? > > I'll take another look this afternoon. LGTM -- Nathan Bossart Amazon Web Services: https://aws.amazon.com