From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael.paquier@gmail.com>
cc: Igor Korot <ikorot01@gmail.com>,
        pgsql-general <pgsql-general@postgresql.org>
Subject: Re: Retrieving query results
In-reply-to: 
 <CAB7nPqR=zNbnsuX78TAuKa=3oZhuKn0JHR7ufvYfVcGdc7ZvyQ@mail.gmail.com>
References: 
 <CA+FnnTxyLWyjY1goewmJNxC==HQCCF4fKkoCTa9qR36oRAHDPw@mail.gmail.com>
 <CAB7nPqTzPvrwDakXjogGCLZGfMpQO1AMWY3e3RMp7SsDGvdUSw@mail.gmail.com>
 <32584.1503579096@sss.pgh.pa.us>
 <CA+FnnTxaA2cuEQiMx4-XFwBX3mdFL5wRq_xcN_+chNM-HdQtYg@mail.gmail.com>
 <14978.1503586593@sss.pgh.pa.us>
 <CAB7nPqSE5voeA5LTDZ6PLkA4jNWuYB7nJJTaXRJBREH2LJE2Fg@mail.gmail.com>
 <17247.1503616204@sss.pgh.pa.us>
 <CAB7nPqR=zNbnsuX78TAuKa=3oZhuKn0JHR7ufvYfVcGdc7ZvyQ@mail.gmail.com>
Comments: In-reply-to Michael Paquier <michael.paquier@gmail.com>
	message dated "Sat, 26 Aug 2017 22:29:56 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <20936.1503760366.1@sss.pgh.pa.us>
Date: Sat, 26 Aug 2017 11:12:46 -0400
Message-ID: <20937.1503760366@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-general-owner@postgresql.org

Michael Paquier <michael.paquier@gmail.com> writes:
> On Fri, Aug 25, 2017 at 8:10 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I think the real problem occurs where we realloc the array bigger.

> Looking at the surroundings, I think that it would be nice to have
> pqAddTuple and PQsetvalue set an error message with this patch.

Yeah, I was thinking about that myself - the existing design presumes
that the only possible reason for failure of pqAddTuple is OOM, but
it'd be better to distinguish "too many tuples" from true OOM.  So
we should also refactor to make pqAddTuple responsible for setting
the error message.  Might be best to do the refactoring first.

			regards, tom lane


-- 
Sent via pgsql-general mailing list (pgsql-general@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-general