Message-ID: <220cb128-4f52-237b-66d8-8dbcd75ead53@dunslane.net>
Date: Tue, 5 Jul 2022 14:52:57 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [UNVERIFIED SENDER] Re: pg_upgrade can result in early wraparound
 on databases with high transaction load
Content-Language: en-US
To: Tom Lane <tgl@sss.pgh.pa.us>, Bruce Momjian <bruce@momjian.us>
Cc: "Drouvot, Bertrand" <bdrouvot@amazon.com>,
 Andres Freund <andres@anarazel.de>, Justin Pryzby <pryzby@telsasoft.com>,
 Noah Misch <noah@leadboat.com>, Jason Harvey <jason@reddit.com>,
 Peter Geoghegan <pg@bowt.ie>, pgsql-hackers@postgresql.org,
 "Tharakan, Robins" <tharar@amazon.com>
References: 
 <CALSof1GM6i21BLr8PsFiRYazakojvesdc+_MiR-L_V5NNkRuWg@mail.gmail.com>
 <CAH2-Wz=9Cj8H0=GAiHducPETWf6ZXEzjk_pFkjPWnWH6hptpLA@mail.gmail.com>
 <20190615183759.GB239428@rfd.leadboat.com>
 <20210423234256.hwopuftipdmp3okf@alap3.anarazel.de>
 <20210424002827.GO7256@telsasoft.com>
 <20210424010005.fttcfskp3unr4jiu@alap3.anarazel.de>
 <fe006d56-85f1-5f1e-98e7-05b53dff4f51@amazon.com>
 <78bf65ea-517a-51ed-947b-9728a6ace513@amazon.com>
 <20210727023904.GA19774@momjian.us> <1973418.1657040382@sss.pgh.pa.us>
From: Andrew Dunstan <andrew@dunslane.net>
In-Reply-To: <1973418.1657040382@sss.pgh.pa.us>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/220cb128-4f52-237b-66d8-8dbcd75ead53%40dunslane.net>
Precedence: bulk


On 2022-07-05 Tu 12:59, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
>> This patch has been applied back to 9.6 and will appear in the next
>> minor release.
> I have just discovered that this patch broke pg_upgrade's ability
> to upgrade from 8.4:
>
> $ pg_upgrade -b ~/version84/bin -d ...
> Performing Consistency Checks
> -----------------------------
> Checking cluster versions                                   ok
> The source cluster lacks some required control information:
>   latest checkpoint oldestXID
>
> Cannot continue without required control information, terminating
> Failure, exiting
>
> Sure enough, 8.4's pg_controldata doesn't print anything about
> oldestXID, because that info wasn't there then.
>
> Given the lack of field complaints, it's probably not worth trying
> to do anything to restore that capability.  But we really ought to
> update pg_upgrade's code and docs in pre-v15 branches to say that
> the minimum supported source version is 9.0.


So it's taken us a year to discover the issue :-( Perhaps if we're going
to say we support upgrades back to 9.0 we should have some testing to be
assured we don't break it without knowing like this. I'll see if I can
coax crake to do that - it already tests back to 9.2.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com