public inbox for [email protected]  

help / color / mirror / Atom feed

Re: ERROR wrong varnullingrels (b 3) (expected (b)) with LEFT JOIN LATERAL and CTE
3+ messages / 2 participants
[nested] [flat]

* Re: ERROR wrong varnullingrels (b 3) (expected (b)) with LEFT JOIN LATERAL and CTE
@ 2024-11-28 18:51 Tom Lane <[email protected]>
  2024-11-28 22:35 ` Re: ERROR wrong varnullingrels (b 3) (expected (b)) with LEFT JOIN LATERAL and CTE Tom Lane <[email protected]>
  0 siblings, 1 reply; 3+ messages in thread

From: Tom Lane @ 2024-11-28 18:51 UTC (permalink / raw)
  To: Bertrand Mamasam <[email protected]>; +Cc: pgsql-general

Bertrand Mamasam <[email protected]> writes:
> Ok thank you, here is a short version of the query that works before 16.5
> but not in 16.5+ anymore.

Thanks for the test case!  A quick "git bisect" says I broke it at

cb8e50a4a09fe541e32cd54ea90a97f2924121a1 is the first bad commit
commit cb8e50a4a09fe541e32cd54ea90a97f2924121a1
Author: Tom Lane <[email protected]>
Date:   Fri Aug 30 12:42:12 2024 -0400

    Avoid inserting PlaceHolderVars in cases where pre-v16 PG did not.

Apparently that change was less safe than I thought.  Looking ...

			regards, tom lane






^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: ERROR wrong varnullingrels (b 3) (expected (b)) with LEFT JOIN LATERAL and CTE
  2024-11-28 18:51 Re: ERROR wrong varnullingrels (b 3) (expected (b)) with LEFT JOIN LATERAL and CTE Tom Lane <[email protected]>
@ 2024-11-28 22:35 ` Tom Lane <[email protected]>
  2024-11-28 23:13   ` Re: ERROR wrong varnullingrels (b 3) (expected (b)) with LEFT JOIN LATERAL and CTE Bertrand Mamasam <[email protected]>
  0 siblings, 1 reply; 3+ messages in thread

From: Tom Lane @ 2024-11-28 22:35 UTC (permalink / raw)
  To: Bertrand Mamasam <[email protected]>; +Cc: pgsql-general

I wrote:
> Thanks for the test case!  A quick "git bisect" says I broke it at
> cb8e50a4a09fe541e32cd54ea90a97f2924121a1 is the first bad commit
> commit cb8e50a4a09fe541e32cd54ea90a97f2924121a1
> Author: Tom Lane <[email protected]>
> Date:   Fri Aug 30 12:42:12 2024 -0400
>     Avoid inserting PlaceHolderVars in cases where pre-v16 PG did not.
> Apparently that change was less safe than I thought.  Looking ...

Fixed here:

https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=85990e2fd5610576635c65db9292297b1...

Thanks for the report!

			regards, tom lane






^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: ERROR wrong varnullingrels (b 3) (expected (b)) with LEFT JOIN LATERAL and CTE
  2024-11-28 18:51 Re: ERROR wrong varnullingrels (b 3) (expected (b)) with LEFT JOIN LATERAL and CTE Tom Lane <[email protected]>
  2024-11-28 22:35 ` Re: ERROR wrong varnullingrels (b 3) (expected (b)) with LEFT JOIN LATERAL and CTE Tom Lane <[email protected]>
@ 2024-11-28 23:13   ` Bertrand Mamasam <[email protected]>
  0 siblings, 0 replies; 3+ messages in thread

From: Bertrand Mamasam @ 2024-11-28 23:13 UTC (permalink / raw)
  To: pgsql-general

On Thu, Nov 28, 2024 at 11:35 PM Tom Lane <[email protected]> wrote:

> I wrote:
> > Thanks for the test case!  A quick "git bisect" says I broke it at
> > cb8e50a4a09fe541e32cd54ea90a97f2924121a1 is the first bad commit
> > commit cb8e50a4a09fe541e32cd54ea90a97f2924121a1
> > Author: Tom Lane <[email protected]>
> > Date:   Fri Aug 30 12:42:12 2024 -0400
> >     Avoid inserting PlaceHolderVars in cases where pre-v16 PG did not.
> > Apparently that change was less safe than I thought.  Looking ...
>
> Fixed here:
>
>
> https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=85990e2fd5610576635c65db9292297b1...
>
> Thanks for the report!
>

Excellent ! Thank you very much !!!

Bertrand


^ permalink  raw  reply  [nested|flat] 3+ messages in thread

end of thread, other threads:[~2024-11-28 23:13 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-11-28 18:51 Re: ERROR wrong varnullingrels (b 3) (expected (b)) with LEFT JOIN LATERAL and CTE Tom Lane <[email protected]>
2024-11-28 22:35 ` Tom Lane <[email protected]>
2024-11-28 23:13   ` Bertrand Mamasam <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox