From: Tom Lane <tgl@sss.pgh.pa.us>
To: Stephen Frost <sfrost@snowman.net>
cc: Gustavsson Mikael <mikael.gustavsson@smhi.se>,
        Magnus Hagander <magnus@hagander.net>,
        Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
        "pgsql-general@postgresql.org" <pgsql-general@postgresql.org>,
        Svensson Peter <peter.svensson@smhi.se>
Subject: Re: Problem with ssl and psql in Postgresql 13
In-reply-to: <20201230150039.GZ27507@tamriel.snowman.net>
References: <737386.1608757126@sss.pgh.pa.us>
 <20201223211448.GR27507@tamriel.snowman.net>
 <738715.1608758847@sss.pgh.pa.us>
 <20201223214534.GS27507@tamriel.snowman.net>
 <740093.1608760567@sss.pgh.pa.us> <742641.1608762845@sss.pgh.pa.us>
 <1308863.1609016410@sss.pgh.pa.us> <1333636.1609020377@sss.pgh.pa.us>
 <1528843.1609108374@sss.pgh.pa.us> <2187460.1609263156@sss.pgh.pa.us>
 <20201230150039.GZ27507@tamriel.snowman.net>
Comments: In-reply-to Stephen Frost <sfrost@snowman.net>
	message dated "Wed, 30 Dec 2020 10:00:40 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2344141.1609346474.1@sss.pgh.pa.us>
Date: Wed, 30 Dec 2020 11:41:14 -0500
Message-ID: <2344142.1609346474@sss.pgh.pa.us>
Precedence: bulk

Stephen Frost <sfrost@snowman.net> writes:
> * Tom Lane (tgl@sss.pgh.pa.us) wrote:
>> I think we'd be best off to always override KRB5_KTNAME if we have a
>> nonempty krb_server_keyfile setting, so the attached proposed patch
>> makes both functions do it the same way.  (I did not make an effort
>> to remove the dependency on setenv, given the nearby thread to
>> standardize on that.)

> +1.

Done, thanks for looking at the patch.

>> I'm not sure whether there's any documentation change that needs to
>> be made.  The docs don't suggest that you're allowed to set
>> krb_server_keyfile to an empty string in the first place, so maybe
>> we needn't explain what happens if you do.

> Perhaps saying something about 'system default' or 'taken from the
> environment' might make sense.

I went with "If this parameter is set to an empty string, it is ignored
and a system-dependent default is used."  I don't think we need to go
into more detail than that, since as you say it's unlikely to be a
useful case.

			regards, tom lane