Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vNyFQ-003iEL-2R for pgsql-general@arkaria.postgresql.org; Tue, 25 Nov 2025 18:58:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vNyFP-00AodQ-0u for pgsql-general@arkaria.postgresql.org; Tue, 25 Nov 2025 18:58:43 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vNyFO-00Aod8-2h for pgsql-general@lists.postgresql.org; Tue, 25 Nov 2025 18:58:43 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by makus.postgresql.org with smtp (Exim 4.96) (envelope-from ) id 1vNyFL-001RSj-1Y for pgsql-general@lists.postgresql.org; Tue, 25 Nov 2025 18:58:42 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id C830248B9C7 for ; Tue, 25 Nov 2025 19:58:36 +0100 (CET) Received: from s980.loopia.se (unknown [172.22.191.6]) by s807.loopia.se (Postfix) with ESMTP id AFDAA48A6F3; Tue, 25 Nov 2025 19:58:36 +0100 (CET) Received: from s474.loopia.se (unknown [172.22.191.5]) by s980.loopia.se (Postfix) with ESMTP id AE65B2201686; Tue, 25 Nov 2025 19:58:36 +0100 (CET) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1.2 X-Spam-Level: X-Spam-Status: No, score=-1.2 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1] autolearn=disabled Authentication-Results: s474.loopia.se (amavisd-new); dkim=pass (2048-bit key) header.d=yesql.se Received: from s899.loopia.se ([172.22.191.5]) by s474.loopia.se (s474.loopia.se [172.22.190.14]) (amavisd-new, port 10024) with LMTP id HddWzqWvVVZy; Tue, 25 Nov 2025 19:58:36 +0100 (CET) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 89.255.232.236 Received: from smtpclient.apple (customer-89-255-232-236.stosn.net [89.255.232.236]) (Authenticated sender: daniel@yesql.se) by s899.loopia.se (Postfix) with ESMTPSA id 287DD2C8BA6F; Tue, 25 Nov 2025 19:58:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yesql.se; s=loopiadkim1707475645; t=1764097116; bh=1gS+YD7HF+HWcpE9T5bWUO8ipK10iasgiffUkyxEGDY=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=FHydslbesiGhN/oo/a5Hk9QeYBKKw74Pyv+jPEvt/KjIdISWLISVA8yErBUR3i09m 9Ty8zf7Ip38zonRCKcfbXEzZCbjSJZwvJEbtFF99QEy0ChnKvzFxjaDU4dJJcad2gc 2i47Z6uP+rX9rn0VwLlRpGa6raEtNp03SG7gmQHpQdTDkiHDApUfFeINFf+I6uxwls rd7GA1U61Fp/UY1ST6quTtrzEGSxZvK0W4RkCvlppavtWZ4KWCwM7jgBJPFVi8qevl YLVLIqbo1U15qjRbnq4xPg3ftHOt7Ggi33FPjnWlJ6RFB39tLmxTQC6J5YHTK5fYqW LEbFSUQEqC6uw== Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.2\)) Subject: Re: Indentation in a patch From: Daniel Gustafsson In-Reply-To: Date: Tue, 25 Nov 2025 19:58:25 +0100 Cc: pgsql-general@lists.postgresql.org Content-Transfer-Encoding: quoted-printable Message-Id: <2595B96D-0A6E-472D-964A-8E87EC3B1C6B@yesql.se> References: To: Bernice Southey X-Mailer: Apple Mail (2.3776.700.51.11.2) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On 25 Nov 2025, at 19:14, Bernice Southey = wrote: > .. for my first ever patch attempt. Awesome, we love to see new contributors! > I'm tempted to submit my patch without indenting the > if-block, and an explanation. That's perfectly fine, an incorrectly indentend diff is fine to submit = if it makes it more readable (especially when coupled with a note explaining = why). > While I'm asking, I added a regression test and ran make check-world > with the TAP tests. Anything else I should do before sending it to > hackers? Sounds like you've completed all the required steps. -- Daniel Gustafsson