pg.ddx.io  pgsql-general@postgresql.org mailing list archive  
help / color / mirror / Atom feed
Two test failures on v16 (compared to v14)
2+ messages / 2 participants
[nested] [flat]

* Two test failures on v16 (compared to v14)
@ 2024-02-14 10:40 Dominique Devienne <ddevienne@gmail.com>
  2024-02-14 15:09 ` Re: Two test failures on v16 (compared to v14) Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 1 reply; 2+ messages in thread

From: Dominique Devienne @ 2024-02-14 10:40 UTC (permalink / raw)
  To: pgsql-general@lists.postgresql.org

Just an FYI. Running the same test suite against V16 triggered two failures.

First, a test of getting the direct members of a role failed.
Returned one more role. The role that created the introspected role.
That's the new CREATEROLE semantic, which adds the role creator
as a direct member of the created role, with admin option.

Second, a LO test failed to open a given OID.
The test starts a read-only transaction, then tries a loOpen(oid,
INV_WRITE),
but does only a loRead(). Now in v16, the loOpen fails, returning -1, while
it used to be OK.
So this must be a bug fix of some kind I guess. Using INV_READ fixed the
test.

I was not expecting failures, but both have good reasons and are easily
fixed. FWIW. --DD

^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: Two test failures on v16 (compared to v14)
  2024-02-14 10:40 Two test failures on v16 (compared to v14) Dominique Devienne <ddevienne@gmail.com>
@ 2024-02-14 15:09 ` Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 2+ messages in thread

From: Tom Lane @ 2024-02-14 15:09 UTC (permalink / raw)
  To: Dominique Devienne <ddevienne@gmail.com>; +Cc: pgsql-general@lists.postgresql.org

Dominique Devienne <ddevienne@gmail.com> writes:
> Just an FYI. Running the same test suite against V16 triggered two failures.
> ...
> Second, a LO test failed to open a given OID.
> The test starts a read-only transaction, then tries a loOpen(oid,
> INV_WRITE),
> but does only a loRead(). Now in v16, the loOpen fails, returning -1, while
> it used to be OK.
> So this must be a bug fix of some kind I guess. Using INV_READ fixed the
> test.

Yup, see commit 55f480278

			regards, tom lane





^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2024-02-14 15:09 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-02-14 10:40 Two test failures on v16 (compared to v14) Dominique Devienne <ddevienne@gmail.com>
2024-02-14 15:09 ` Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox