From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Thomas Munro <thomas.munro@gmail.com>, Kirk Wolak <wolakk@gmail.com>,
        pgsql-general@lists.postgresql.org
Subject: Re: Getting PSQL in Windows to support TAB/Autocomplete via modified
 readline...
In-reply-to: <20221124022205.2uv6lz74qfo7rebn@awork3.anarazel.de>
References: 
 <CACLU5mThm-uCtERMVHMoGED2EPfyS54j83WB20s_BmzVQuMkpg@mail.gmail.com>
 <3168699.1669046286@sss.pgh.pa.us>
 <20221123230256.m23somxrmvdyoimk@awork3.anarazel.de>
 <3755435.1669245082@sss.pgh.pa.us>
 <20221124004144.iosgze2qnmcctgsh@awork3.anarazel.de>
 <3769352.1669253309@sss.pgh.pa.us>
 <20221124022205.2uv6lz74qfo7rebn@awork3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Wed, 23 Nov 2022 18:22:05 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3778126.1669258650.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 23 Nov 2022 21:57:30 -0500
Message-ID: <3778127.1669258650@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3778127.1669258650%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> I think it'd be easier to deal with this if COMPLETE_WITH_* caused the t=
he
> containing function to return. Then the completions wouldn't need to be =
in one
> huge if-else if. Leaving msvc aside, that also seems nice for efficiency=
.

Yeah, that could be an easy quick-fix.  We'd need to refactor so that
the cleanup housekeeping at the bottom of psql_completion() was in a
wrapper function, but perhaps that wouldn't be too messy.

			regards, tom lane