Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pIYfJ-0002Rr-OG for pgsql-hackers@arkaria.postgresql.org; Thu, 19 Jan 2023 17:25:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pIYfF-0005p0-On for pgsql-hackers@arkaria.postgresql.org; Thu, 19 Jan 2023 17:25:25 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pIYfF-0005oo-Fl for pgsql-hackers@lists.postgresql.org; Thu, 19 Jan 2023 17:25:25 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pIYfD-0007N1-DK for pgsql-hackers@postgresql.org; Thu, 19 Jan 2023 17:25:25 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 30JHPIjP4176212; Thu, 19 Jan 2023 12:25:18 -0500 From: Tom Lane To: Laurenz Albe cc: Torsten =?ISO-8859-1?Q?F=F6rtsch?= , pgsql-hackers@postgresql.org, Michael Paquier Subject: Re: minor bug In-reply-to: <4ae9feb22332aca790968b550f0016a1f97c3739.camel@cybertec.at> References: <2964581.1673969570@sss.pgh.pa.us> <3787515.1674072218@sss.pgh.pa.us> <4ae9feb22332aca790968b550f0016a1f97c3739.camel@cybertec.at> Comments: In-reply-to Laurenz Albe message dated "Thu, 19 Jan 2023 13:57:14 +0100" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <4176210.1674149118.1@sss.pgh.pa.us> Date: Thu, 19 Jan 2023 12:25:18 -0500 Message-ID: <4176211.1674149118@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Laurenz Albe writes: > On Wed, 2023-01-18 at 15:03 -0500, Tom Lane wrote: >> Ah, but that only happens if recoveryTarget == RECOVERY_TARGET_TIME. >> Digging in the git history, I see that this did use to work as >> I remember: we always extracted the record time before printing it. >> That was accidentally broken in refactoring in c945af80c. I think >> the correct fix is more like the attached. > Yes, you are right. Your patch looks fine to me. Pushed then. Thanks for the report! regards, tom lane