Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pIYjh-0002de-8M for pgsql-hackers@arkaria.postgresql.org; Thu, 19 Jan 2023 17:30:01 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pIYjg-0004In-0t for pgsql-hackers@arkaria.postgresql.org; Thu, 19 Jan 2023 17:30:00 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pIYjf-0004Ie-Ng for pgsql-hackers@lists.postgresql.org; Thu, 19 Jan 2023 17:29:59 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pIYjd-0005UT-IM for pgsql-hackers@postgresql.org; Thu, 19 Jan 2023 17:29:58 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 30JHTrp74177260; Thu, 19 Jan 2023 12:29:53 -0500 From: Tom Lane To: =?UTF-8?Q?Torsten_F=C3=B6rtsch?= cc: Laurenz Albe , pgsql-hackers@postgresql.org, Michael Paquier Subject: Re: minor bug In-reply-to: References: <2964581.1673969570@sss.pgh.pa.us> <3787515.1674072218@sss.pgh.pa.us> Comments: In-reply-to =?UTF-8?Q?Torsten_F=C3=B6rtsch?= message dated "Thu, 19 Jan 2023 18:18:04 +0100" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <4177258.1674149393.1@sss.pgh.pa.us> Date: Thu, 19 Jan 2023 12:29:53 -0500 Message-ID: <4177259.1674149393@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk =?UTF-8?Q?Torsten_F=C3=B6rtsch?= writes: > Why not > (void)getRecordTimestamp(record, &recordXtime); > if (recoveryTarget == RECOVERY_TARGET_TIME) > ... Could've done it like that, but I already pushed the other version, and I don't think it's worth the trouble to change. regards, tom lane