From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Christoph Berg <myon@debian.org>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
        ma lz <ma100@hotmail.com>
Subject: Re: query_id: jumble names of temp tables for better pg_stat_statement UX
In-reply-to: <Z99aIy9T0f-lulK5@paquier.xyz>
References: <Z9mkqplmUpQ4xG52@msg.df7cb.de> <Z9n_K2YGbadpzD_s@paquier.xyz> <Z9qybg3FxTUefRT7@msg.df7cb.de> <Z9y43-dRvb4EtxQ0@paquier.xyz> <Z92TLJ5MmSU_lyxa@msg.df7cb.de> <Z93sH12uzCQHfOo-@paquier.xyz> <Z96GJEmTnvHKz_Kn@msg.df7cb.de> <Z96Rz-4IEyRCS4ny@paquier.xyz> <1831838.1742656359@sss.pgh.pa.us> <80506.1742660683@sss.pgh.pa.us> <Z99aIy9T0f-lulK5@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Sun, 23 Mar 2025 09:47:31 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <461404.1742691859.1@sss.pgh.pa.us>
Date: Sat, 22 Mar 2025 21:04:19 -0400
Message-ID: <461405.1742691859@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/461405.1742691859%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> Alias.aliasname is not qualified, so it means that we'd begin to
> assign the same query ID even if using two relations from two schemas
> depending on what search_path assigns, no?

Right.  I'm arguing that that's good.  The proposed patch already
obscures the difference between similar table names in different
(temp) schemas, and I'm suggesting that taking that a bit further
would be fine.

Note that if the tables we're considering don't have identical
rowtypes, the queries would likely jumble differently anyway
due to differences in Vars' varattno and vartype.

			regards, tom lane