From: Tom Lane <tgl@sss.pgh.pa.us>
To: Adrian Klaver <adrian.klaver@aklaver.com>
cc: "Tefft, Michael J" <Michael.J.Tefft@snapon.com>,
        pgsql-hackers@lists.postgresql.org,
        Melanie Plageman <melanieplageman@gmail.com>
Subject: Re: Capturing both IP address and hostname in the log
In-reply-to: <97cfc252-9a26-489e-b458-999ac5589224@aklaver.com>
References: <BN8PR04MB550874EE58EC715656C3D3D2D0B72@BN8PR04MB5508.namprd04.prod.outlook.com> <97cfc252-9a26-489e-b458-999ac5589224@aklaver.com>
Comments: In-reply-to Adrian Klaver <adrian.klaver@aklaver.com>
	message dated "Thu, 10 Apr 2025 08:22:56 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <525678.1744300832.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Thu, 10 Apr 2025 12:00:32 -0400
Message-ID: <525679.1744300832@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/525679.1744300832%40sss.pgh.pa.us>
Precedence: bulk

[ moving to -hackers ]

Adrian Klaver <adrian.klaver@aklaver.com> writes:
> On 4/10/25 05:22, Tefft, Michael J wrote:
>> We have set log_hostname ON and we get hostname reported – but we do not 
>> get IP address. We would like to capture both.
>> Is there a way to capture both IP address and hostname in the log 
>> messages? Or must we choose “one or the ootehr”?

> I see the same thing. It seems either or.

Melanie recently committed a patch (9219093ca) that purports to
generalize our log_connections logging ability:

    Convert the boolean log_connections GUC into a list GUC comprised of the
    connection aspects to log.
    
    This gives users more control over the volume and kind of connection
    logging.
    
    The current log_connections options are 'receipt', 'authentication', and
    'authorization'. The empty string disables all connection logging. 'all'
    enables all available connection logging.

I wonder if it'd be reasonable to remove the separate log_hostname GUC
and fold it into this infrastructure, and while doing so make it
possible to log either or both of the client IP address and hostname.
(For that matter, I think there is interest in being able to capture
the server IP address too, cf 3516ea768.  You might wish to log the
IP address only once, not in every log line.)

			regards, tom lane