Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1gK9b1-0001tD-EN for pgsql-general@arkaria.postgresql.org; Tue, 06 Nov 2018 22:13:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gK9az-0007qL-Pa for pgsql-general@arkaria.postgresql.org; Tue, 06 Nov 2018 22:13:13 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1gK9Zf-0005Jv-9p; Tue, 06 Nov 2018 22:11:51 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1gK9Za-0005Nz-Vw; Tue, 06 Nov 2018 22:11:49 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id wA6MBetg005324; Tue, 6 Nov 2018 17:11:40 -0500 From: Tom Lane To: Andres Freund cc: =?utf-8?Q?Ond=C5=99ej?= Bouda , Alvaro Herrera , pgsql-hackers@lists.postgresql.org, pgsql-general@lists.postgresql.org Subject: Re: backend crash on DELETE, reproducible locally In-reply-to: <20181106215457.h36ccb5wywatcqhz@alap3.anarazel.de> References: <20181106194553.dynhd2xuivo56ymd@alvherre.pgsql> <33d144b9-5208-8d32-7e95-94ed4d2931b8@email.cz> <450.1541535425@sss.pgh.pa.us> <134c09b5-3eb0-bafd-2aeb-f383e1e21b8a@email.cz> <2432.1541538215@sss.pgh.pa.us> <2877.1541538838@sss.pgh.pa.us> <4375.1541540840@sss.pgh.pa.us> <20181106215457.h36ccb5wywatcqhz@alap3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Tue, 06 Nov 2018 13:54:57 -0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <5322.1541542300.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Tue, 06 Nov 2018 17:11:40 -0500 Message-ID: <5323.1541542300@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Andres Freund writes: > On 2018-11-06 16:47:20 -0500, Tom Lane wrote: >> Looks like somebody forgot to list >> RELOPT_KIND_GIST in RELOPT_KIND_INDEX, but is that the >> fault of commit c203d6cf8 or was it busted before? > Looks new: > + RELOPT_KIND_INDEX =3D RELOPT_KIND_BTREE|RELOPT_KIND_HASH|RELOPT_KIND= _GIN|RELOPT_KIND_SPGIST, > there aren't any other "for all indexes" type options, so the whole > category didn't exist before. > It also strikes me as a really bad idea, even if RELOPT_KIND_GIST > wouldn't have been omitted: It breaks index am extensibility. Hm, well, that enum already knows about all index types, doesn't it? regards, tom lane