Subject: Re: 9.5 beta pg_upgrade documentation
To: Bruce Momjian <bruce@momjian.us>
References: <55D789B5.7040308@squeakycode.net>
 <55D9DC9E.8080806@squeakycode.net> <20150901210904.GA27334@momjian.us>
Cc: pgsql-general@postgresql.org
From: Andy Colson <andy@squeakycode.net>
Message-ID: <55E63B1B.80603@squeakycode.net>
Date: Tue, 1 Sep 2015 18:56:11 -0500
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <20150901210904.GA27334@momjian.us>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-general-owner@postgresql.org

On 09/01/2015 04:09 PM, Bruce Momjian wrote:
> On Sun, Aug 23, 2015 at 09:45:50AM -0500, Andy Colson wrote:
>> I think we should add a step 6.5 (before step 7 Stop both servers) with something like:
>>
>> If you are upgrading both a primary and standby, then we need to make sure the standby is caught up.
>> If you are wal shipping then on primary run: select pg_switch_xlog();
>> shut down primary
>> before you shut down the standby make sure it gets caught up to the primary.
>>
>> I don't think its 100% required for them to be exact, is it?  If they are a little different then rsync has more data to xfer from primary to standby ... but it would still work.  Right?
>
> You are one of the first to use this new ability so it is good to get
> your feedback.  I have developed the attached applied patch to address
> the problems you saw.
>
> First, the verification has to happen earlier, before pg_upgrade is run.
> I think what is happening is that a checkpoint on server shutdown is
> changing the value while pg_upgrade is running, and the rename of the
> controldata file is another issue, so doing it right after the primary
> is shut down is the right place.
>
> I also added a mention that rsync, not pg_upgrade, will be run on the
> standbys.  You can see all the results of the patch here:
>
> 	http://momjian.us/pgsql_docs/pgupgrade.html
>
> Thanks.
>

Sweet, I'm glad I stopped where I did.  I think I'm safe to pick up at step f.  Which seemed to work ok.  But now we get to step g (run rsync).  I checked the rsync manual and don't see anything like this three directory argument thing you are trying to run.  Unless you want to use --link-dest.  In which case I think the cmd would be like:

rsync --archive --delete --hard-links --size-only --link-dest=old_pgdata new_pgdata remote_dir

I'm gonna try this now, will report back.

-Andy


-- 
Sent via pgsql-general mailing list (pgsql-general@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-general