public inbox for [email protected]  
help / color / mirror / Atom feed
From: Tom Lane <[email protected]>
To: Nathan Bossart <[email protected]>
Cc: [email protected]
Cc: Peter Eisentraut <[email protected]>
Cc: Victor Yegorov <[email protected]>
Cc: Pierre Forstmann <[email protected]>
Subject: Re: Unexpected results from CALL and AUTOCOMMIT=off
Date: Tue, 04 Jun 2024 16:31:34 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <Zl91WPpX2KElTZbb@nathan>
References: <CAGnEboiRe+fG2QxuBO2390F7P8e2MQ6UyBjZSL_w1Cej+E4=Vw@mail.gmail.com>
	<CAM-sOH80Z=OqYBWgYP=BDGLbxQ72wkC9=tZ-vRKxkmKkhTD7MQ@mail.gmail.com>
	<CAGnEbojf5Awm862ghvooLku6mm0m4yF60PyHQxCinM8pn01sbw@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<Zl91WPpX2KElTZbb@nathan>

Nathan Bossart <[email protected]> writes:
> On Tue, Jun 04, 2024 at 02:28:43PM -0400, Tom Lane wrote:
>> Hence, new patch attached, now with docs and tests.  Barring
>> objections I'll push this one.

> Should we expand the documentation for SPI_connect_ext() to note that
> SPI_execute_extended()/SPI_execute_plan_extended() depend on the flag?

Perhaps.  They already did, in that the atomic flag was taken into
account while deciding how to handle a nested CALL; basically what this
fix does is to make sure that the snapshot handling is done the same
way.  I think that what I added to the docs is probably sufficient,
but I'll yield to majority opinion if people think not.

			regards, tom lane






view thread (6+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Unexpected results from CALL and AUTOCOMMIT=off
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox